[GitHub] anirudh2290 commented on a change in pull request #11492: [MXNET-612] Optimize RAT setup and move it into PR stage

[GitBox <gi...@apache.org>]

anirudh2290 commented on a change in pull request #11492: [MXNET-612] Optimize RAT setup and move it into PR stage
URL: https://github.com/apache/incubator-mxnet/pull/11492#discussion_r199189968
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -783,8 +783,26 @@ build_docs() {
 
 #Runs Apache RAT Check on MXNet Source for License Headers
 nightly_test_rat_check() {
-    set -ex
-    ./tests/nightly/apache_rat_license_check/license_check.sh
+    set -e
+    pushd .
+    
+    cd /work/deps/trunk/apache-rat/target
+
+    # Use shell number 5 to duplicate the log output. It get sprinted and stored in $OUTPUT at the same time https://stackoverflow.com/a/12451419
+    exec 5>&1
+    OUTPUT=$(java -jar apache-rat-0.13-SNAPSHOT.jar -E /work/mxnet/tests/nightly/apache_rat_license_check/rat-excludes -d /work/mxnet|tee >(cat - >&5))
 
 Review comment:
   This may be unrelated but what is file descriptor 5 here. I tried on my machine and it gives bad file descriptor. And when I echo $OUTPUT it says : `Ignored 1 lines in your exclusion files as comments or empty lines.` Maybe its just my env, but it is this rat check verified ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services