You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2020/05/05 16:24:24 UTC
[GitHub] [openmeetings] CkNoSFeRaTU opened a new pull request #76: getDisplayMedia reside in normal place for chromium-based edge
CkNoSFeRaTU opened a new pull request #76:
URL: https://github.com/apache/openmeetings/pull/76
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on a change in pull request #76: getDisplayMedia reside in normal place for chromium-based edge
Posted by GitBox <gi...@apache.org>.
solomax commented on a change in pull request #76:
URL: https://github.com/apache/openmeetings/pull/76#discussion_r420241372
##########
File path: openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video.js
##########
@@ -32,7 +32,10 @@ var Video = (function() {
cnts = {
video: true
};
- promise = navigator.getDisplayMedia(cnts);
+ if (b.major > 80)
Review comment:
could you please add `{}` to this if/else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] solomax commented on pull request #76: [OPENMEETINGS-2346] getDisplayMedia reside in normal place for chromium-based edge
Posted by GitBox <gi...@apache.org>.
solomax commented on pull request #76:
URL: https://github.com/apache/openmeetings/pull/76#issuecomment-624175997
Thanks for the contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openmeetings] CkNoSFeRaTU commented on a change in pull request #76: getDisplayMedia reside in normal place for chromium-based edge
Posted by GitBox <gi...@apache.org>.
CkNoSFeRaTU commented on a change in pull request #76:
URL: https://github.com/apache/openmeetings/pull/76#discussion_r420261759
##########
File path: openmeetings-web/src/main/java/org/apache/openmeetings/web/room/raw-video.js
##########
@@ -32,7 +32,10 @@ var Video = (function() {
cnts = {
video: true
};
- promise = navigator.getDisplayMedia(cnts);
+ if (b.major > 80)
Review comment:
sure, force-pushed with requested changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org