You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/09/10 04:41:41 UTC
[GitHub] [logging-log4cxx] swebb2066 opened a new pull request, #125: Remove asyncappender_nonblocking.cpp
swebb2066 opened a new pull request, #125:
URL: https://github.com/apache/logging-log4cxx/pull/125
asyncappender_nonblocking.cpp was a copy of asyncappender.cpp as at 2018 taken prior to improvements to asyncappender.cpp
The master version of asyncappender_nonblocking.cpp has compileation errors.
I doubt it has ever been used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 commented on pull request #125: Remove asyncappender_nonblocking.cpp
Posted by GitBox <gi...@apache.org>.
rm5248 commented on PR #125:
URL: https://github.com/apache/logging-log4cxx/pull/125#issuecomment-1242712295
Looks good to me, agree that it should be removed.
Side note: I don't think the `$<IF:$<BOOL:LOG4CXX_BLOCKING_ASYNC_APPENDER...` works. When I tried to set the option it didn't seem to change anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] swebb2066 merged pull request #125: Remove asyncappender_nonblocking.cpp
Posted by GitBox <gi...@apache.org>.
swebb2066 merged PR #125:
URL: https://github.com/apache/logging-log4cxx/pull/125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org