You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/07/17 03:42:21 UTC
[GitHub] [geode] gesterzhou opened a new pull request #5381: GEODE-8367: Stopped parallel gateway sender should not add events int…
gesterzhou opened a new pull request #5381:
URL: https://github.com/apache/geode/pull/5381
…o tmpDroppedEvents
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on a change in pull request #5381: GEODE-8367: Stopped parallel gateway sender should not add events int…
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on a change in pull request #5381:
URL: https://github.com/apache/geode/pull/5381#discussion_r456569959
##########
File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java
##########
@@ -1034,9 +1036,17 @@ public void distribute(EnumListenerEvent operation, EntryEventImpl event,
// If this gateway is not running, return
if (!isRunning()) {
if (this.isPrimary()) {
- tmpDroppedEvents.add(clonedEvent);
- if (isDebugEnabled) {
- logger.debug("add to tmpDroppedEvents for evnet {}", clonedEvent);
+ if (this.startTime < 0
+ && System.currentTimeMillis() + this.startTime < maxWaitTimeForSenderToStart) {
+ tmpDroppedEvents.add(clonedEvent);
+ if (isDebugEnabled) {
+ logger.debug("add to tmpDroppedEvents for evnet {}", clonedEvent);
+ }
+ } else {
+ if (isDebugEnabled) {
+ logger.debug("The sender is stopped. Not to add to tmpDroppedEvents for event {}",
Review comment:
This might be worded better as "Gateway sender is stopped. Event was not added to tmpDroppedEvents: {}"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] gesterzhou closed pull request #5381: GEODE-8367: Stopped parallel gateway sender should not add events int…
Posted by GitBox <gi...@apache.org>.
gesterzhou closed pull request #5381:
URL: https://github.com/apache/geode/pull/5381
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org