[GitHub] [druid] rohangarg commented on a diff in pull request #14277: Fixing an issue with filtering on a single dimension by converting In…

["rohangarg (via GitHub)" <gi...@apache.org>]

rohangarg commented on code in PR #14277:
URL: https://github.com/apache/druid/pull/14277#discussion_r1193346628


##########
processing/src/main/java/org/apache/druid/segment/join/JoinableFactoryWrapper.java:
##########
@@ -177,7 +178,10 @@ static JoinClauseToFilterConversion convertJoinToFilter(
         }
         return new JoinClauseToFilterConversion(null, false);
       }
-      final Filter onlyFilter = new InDimFilter(leftColumn, columnValuesWithUniqueFlag.getColumnValues());
+      final Filter onlyFilter = Filters.toFilter(new InDimFilter(

Review Comment:
   It is worth adding a test for this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org