You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by jz...@apache.org on 2022/10/17 13:38:59 UTC
[opennlp] branch master updated: OPENNLP-1386: Making parameters be not case sensitive. (#423)
This is an automated email from the ASF dual-hosted git repository.
jzemerick pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/opennlp.git
The following commit(s) were added to refs/heads/master by this push:
new c5e9bb21 OPENNLP-1386: Making parameters be not case sensitive. (#423)
c5e9bb21 is described below
commit c5e9bb21cca0a68725ce53da06ba8dce36a47680
Author: Jeff Zemerick <13...@users.noreply.github.com>
AuthorDate: Mon Oct 17 09:38:54 2022 -0400
OPENNLP-1386: Making parameters be not case sensitive. (#423)
---
.../src/main/java/opennlp/tools/util/TrainingParameters.java | 3 ++-
.../src/test/java/opennlp/tools/util/TrainingParametersTest.java | 8 ++++++++
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/opennlp-tools/src/main/java/opennlp/tools/util/TrainingParameters.java b/opennlp-tools/src/main/java/opennlp/tools/util/TrainingParameters.java
index 8006a4d6..d69a9b14 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/util/TrainingParameters.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/util/TrainingParameters.java
@@ -25,6 +25,7 @@ import java.util.HashMap;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Properties;
+import java.util.TreeMap;
import opennlp.tools.ml.EventTrainer;
@@ -38,7 +39,7 @@ public class TrainingParameters {
public static final String CUTOFF_PARAM = "Cutoff";
public static final String THREADS_PARAM = "Threads";
- private Map<String, Object> parameters = new HashMap<>();
+ private Map<String, Object> parameters = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
public TrainingParameters() {
}
diff --git a/opennlp-tools/src/test/java/opennlp/tools/util/TrainingParametersTest.java b/opennlp-tools/src/test/java/opennlp/tools/util/TrainingParametersTest.java
index 7c8e41e8..8c14d238 100644
--- a/opennlp-tools/src/test/java/opennlp/tools/util/TrainingParametersTest.java
+++ b/opennlp-tools/src/test/java/opennlp/tools/util/TrainingParametersTest.java
@@ -68,6 +68,14 @@ public class TrainingParametersTest {
Assert.assertEquals("SVM", tp.algorithm("n1"));
}
+ @Test
+ public void testGetAlgorithmCaseInsensitive() {
+ TrainingParameters tp = build("ALGORITHM=Perceptron,n1.Algorithm=SVM");
+
+ Assert.assertEquals("Perceptron", tp.algorithm());
+ Assert.assertEquals("SVM", tp.algorithm("n1"));
+ }
+
@Test
public void testGetSettings() {
TrainingParameters tp = build("k1=v1,n1.k2=v2,n2.k3=v3,n1.k4=v4");