You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Matthew Koch (JIRA)" <ji...@apache.org> on 2007/08/08 00:29:59 UTC
[jira] Created: (DBF-1) Copy images based on type and target
Copy images based on type and target
------------------------------------
Key: DBF-1
URL: https://issues.apache.org/jira/browse/DBF-1
Project: DocBook Framework
Issue Type: Improvement
Environment: Ubuntu Feisty
Reporter: Matthew Koch
Priority: Minor
I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: default.imageincludes
default.imageincludes
Update to previous patch. The includes files are now expected to be in the src/docbook/projectname directory with names akin to projectname.html.imageincludes. If the includes file does not exist, then a default.imageincludes is used from the dbf base directory.
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
> Attachments: default.imageincludes, default.imageincludes
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (DBF-1) Copy images based on type and target
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12518657 ]
Henning Schmiedehausen commented on DBF-1:
------------------------------------------
This is a nice idea. Problem might be that now a docbook author must keep track which image to include where for all types of target media in multiple files. I will look into this over the weekend. Thanks for the patch.
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
> Attachments: default.imageincludes, imageincludes.patch
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: imageincludes.patch
Here's a sample patch for this issue. Change requires a file named docfile.type.imageincludes (ie. Manual.html.includes) in the base directory. Open to suggestions...
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
> Attachments: imageincludes.patch
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: (was: imageincludes.patch)
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: imageincludes.patch
default_imageincludes.txt
Updated patch for extension change. Also, added a paragraph to the documentation explaining the includes file. By default (no project specific includes file) all images are included.
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
> Attachments: default_imageincludes.txt, imageincludes.patch
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Assigned: (DBF-1) Copy images based on type and target
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen reassigned DBF-1:
----------------------------------------
Assignee: Henning Schmiedehausen
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Assignee: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.1
>
> Attachments: default_imageincludes.txt, imageincludes.patch
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: (was: imageincludes.patch)
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: imageincludes.patch
oops, attached wrong file...
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
> Attachments: default.imageincludes, imageincludes.patch
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: (was: default.imageincludes)
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
> Attachments: default.imageincludes, imageincludes.patch
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: (was: default.imageincludes)
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Commented: (DBF-1) Copy images based on type and target
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12523061 ]
Henning Schmiedehausen commented on DBF-1:
------------------------------------------
I think this patch is worth applying if it gets properly documented. Could you add a description "how it works" to the notes section of the manual? There is a section called "Referencing images", I could imagine a section "Selecting images for inclusion".
As I understand your patch, this is strictly optional, so if I don't have a <foo>.images file, then the behaviour is as before, isn't it?
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
> Attachments: default.imageincludes, imageincludes.patch
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Resolved: (DBF-1) Copy images based on type and target
Posted by "Henning Schmiedehausen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henning Schmiedehausen resolved DBF-1.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.1
Patch applied with minor corrections. Thanks Matthew!
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Assignee: Henning Schmiedehausen
> Priority: Minor
> Fix For: 1.1
>
> Attachments: default_imageincludes.txt, imageincludes.patch
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: (was: default.imageincludes)
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: (was: imageincludes.patch)
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org
[jira] Updated: (DBF-1) Copy images based on type and target
Posted by "Matthew Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBF-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Koch updated DBF-1:
---------------------------
Attachment: imageincludes.patch
default.imageincludes
Real uploads this time. doh...
> Copy images based on type and target
> ------------------------------------
>
> Key: DBF-1
> URL: https://issues.apache.org/jira/browse/DBF-1
> Project: DocBook Framework
> Issue Type: Improvement
> Environment: Ubuntu Feisty
> Reporter: Matthew Koch
> Priority: Minor
> Attachments: default.imageincludes, imageincludes.patch
>
>
> I noticed in the DBF documentation that there is a TODO item to not blindly copy images. Would an acceptable solution be to add an 'includesfile' to the fileset for the copy task for images based on the target (and if desirable on the type)? For example, for the 'pdf' type of the 'manual' target there could be a file called manual.pdf.image.includes that would specify which images to include/exclude. I haven't tested the behavior of the includesfile attribute much, so it may be necessary to have a default includesfile with "images/**".
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org