You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gravitino.apache.org by Justin Mclean <ju...@classsoftware.com> on 2024/09/02 02:39:23 UTC

RE: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Hi,

-1 (binding) as some files are misisng incubating in their names, but if those files are renamed, then +1 (binding)

Several LICENSE and NOTICE files need updating, but that’s OK due to the WIP disclaimer.

Testing on mocOS I checked:
- Not all artifact names include incubating in them, e.g. apache_gravitino-0.6.0.tar.gz. This needs to be fixed, but there is no need for a new RC or vote, just rename the files.
- Signatures and hashes are fine.
- DISCLAIMER (WIP), NOTICE and LICENSE exist in all artifacts.
- The LICENSE and NOTICE is incorrect for apache_gravitino-0.6.0.tar.gz, same with the licenses directory. The LICENSE and NOTICE files need to reflect what is in the release artifact, and it seems the binary LICENSE and NOTICE files for the Java release have been copied here. In this case of the stock LICENSE file, adding "MIT License Copyright (c) 2016 Dhamu” is all that is needed. BTW do we know what project this code comes from?
- Similarly, the LICENSE and NOTICE files for gravitino-iceberg-rest-server-0.6.0-incubating-bin and gravitino-trino-connector-0.6.0-incubating need to be updated to reflect what is in them.
- The main gravitino LICENSE is missing a license for TCPDS. I couldn't find out this data was licenced from a quick search. Do we know how the data is licensed?
- all ASF files have the correct header, although perhaps it could be added to some XML files.
- No unexpected binary files in the source release
- Compile fails due to rat issues, but can compile from source (and test pass) with the addition of -x rat

Other minor issues:
- The KEY file needs to be in https://dist.apache.org/repos/dist/release/incubator/gravitino/
- I think gravitino-trino-connector-0.6.0-incubating.tar.gz should include a “-bin” in the name as it’s not source code. Again, this can be renamed without a new RC or vote.
- Is the source code for gravitino-trino-connector-0.6.0-incubating and gravitino-iceberg-rest-server-0.6.0-incubating included in the release? (I am asking this in case this comes up in the IPMC vote).
- The rat test fails when building the source. The files it fails on are acceptable, except for possibly some XML files.
- Do the “.github” and “.gitattributes” files need to be in the source release?
- The Python client README.md build instruction needs to be updated as they assume it part of the main gravitino repo


Kind Regards,
Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

We should be good if we follow the guidelines here [1].

Kind Regards,
Justin

1. https://cwiki.apache.org/confluence/display/INCUBATOR/Distribution+Guidelines

> On 2 Sep 2024, at 4:12 PM, Jerry Shao <js...@apache.org> wrote:
> 
> I just found out that version "0.6.0.incubating" doesn't conform to PEP440,
> the only supported versions are like:
> 
> 0.1.0
> 0.1.0a1 for alpha release
> 0.1.0b1 for beta release
> 0.1.0rc1 for rc release
> 
> We cannot have a name like x.y.z.incubating for publishing. So for Python
> release we cannot add "incubating" into the package name. I also checked
> various incubating projects, all of them don't have "incubating" in their
> package version or name. Do we have any better solution?
> 
> Besides, we don't ship Python distribution using ASF mirror system, we
> should use Pypi. So we don't have to upload Python package to the SVN, I
> will delete them from SVN.
> 
> Best,
> Jerry
> 
> 
> Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 22:55写道：
> 
>> Hi,
>> 
>>> This Python package name is generated from Python configuration file and
>>> its version number, we cannot simply rename the package name using mv,
>>> otherwise, it will be failed to upload to Pypi and install.
>> 
>> Yes we can there isn’t anything preventing us from have two slightly
>> different names in different places. Remember the only official
>> distribution is the ASF mirror system.
>> 
>>> The only thing we can do is change the version number to
>> "0.6.0.incubating"
>>> ("-" is not allowed for Python version numbers) and re-package them. Is
>> the
>>> version number "0.6.0.incubating" ok for you?
>> 
>> That would also work.
>> 
>>> Yeah, the readme is more about how to build from scratch. This Python
>>> package is a release package that can be used directly, no need to
>> compile.
>>> The README can be improved, but it's not a blocking thing here.
>> 
>> As I said it was a minor issue, not a blocking one. I mentioned it as it
>> may be an issue that the IPMC brings up as they woudl probably not be able
>> to compile that package without some guidance that’s not in the README.
>> 
>> Kind Regards,
>> Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Jerry Shao <js...@apache.org>.
I just found out that version "0.6.0.incubating" doesn't conform to PEP440,
the only supported versions are like:

0.1.0
0.1.0a1 for alpha release
0.1.0b1 for beta release
0.1.0rc1 for rc release

We cannot have a name like x.y.z.incubating for publishing. So for Python
release we cannot add "incubating" into the package name. I also checked
various incubating projects, all of them don't have "incubating" in their
package version or name. Do we have any better solution?

Besides, we don't ship Python distribution using ASF mirror system, we
should use Pypi. So we don't have to upload Python package to the SVN, I
will delete them from SVN.

Best,
Jerry


Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 22:55写道：

> Hi,
>
> > This Python package name is generated from Python configuration file and
> > its version number, we cannot simply rename the package name using mv,
> > otherwise, it will be failed to upload to Pypi and install.
>
> Yes we can there isn’t anything preventing us from have two slightly
> different names in different places. Remember the only official
> distribution is the ASF mirror system.
>
> > The only thing we can do is change the version number to
> "0.6.0.incubating"
> > ("-" is not allowed for Python version numbers) and re-package them. Is
> the
> > version number "0.6.0.incubating" ok for you?
>
> That would also work.
>
> > Yeah, the readme is more about how to build from scratch. This Python
> > package is a release package that can be used directly, no need to
> compile.
> > The README can be improved, but it's not a blocking thing here.
>
> As I said it was a minor issue, not a blocking one. I mentioned it as it
> may be an issue that the IPMC brings up as they woudl probably not be able
> to compile that package without some guidance that’s not in the README.
>
> Kind Regards,
> Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> This Python package name is generated from Python configuration file and
> its version number, we cannot simply rename the package name using mv,
> otherwise, it will be failed to upload to Pypi and install.

Yes we can there isn’t anything preventing us from have two slightly different names in different places. Remember the only official distribution is the ASF mirror system.

> The only thing we can do is change the version number to "0.6.0.incubating"
> ("-" is not allowed for Python version numbers) and re-package them. Is the
> version number "0.6.0.incubating" ok for you?

That would also work.

> Yeah, the readme is more about how to build from scratch. This Python
> package is a release package that can be used directly, no need to compile.
> The README can be improved, but it's not a blocking thing here.

As I said it was a minor issue, not a blocking one. I mentioned it as it may be an issue that the IPMC brings up as they woudl probably not be able to compile that package without some guidance that’s not in the README.

Kind Regards,
Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Saisai Shao <sa...@gmail.com>.
Hi Justin,

Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 22:37写道：

> Hi,
>
> > For Python release "apache_gravitino-0.6.0.tar.gz" version, as far as I
> > know, Python doesn't support version like "0.6.0-incubating", so I only
> > keep the 0.6.0 delibrately. I also refer to some other incubating
> projects
> > like HugeGraph (https://pypi.org/project/hugegraph-python/#history),
> seems
> > they also don't add the "incubating" in their version.
>
> We must change this (easy enough to do with "svn mv") as all artifacts
> need ”incubating” in their name. See [1] "The release archive(s) MUST
> include the word "incubating" in the filename."
>

This Python package name is generated from Python configuration file and
its version number, we cannot simply rename the package name using mv,
otherwise, it will be failed to upload to Pypi and install.

The only thing we can do is change the version number to "0.6.0.incubating"
("-" is not allowed for Python version numbers) and re-package them. Is the
version number "0.6.0.incubating" ok for you?


>
> >> - The Python client README.md build instruction needs to be updated as
> >> they assume it part of the main gravitino repo
> >>
> >>
> > Python README.md already reflects the Python things including how to
> build
> > Python package, can you please point out what specific issue it is?
>
> Its context is outside of that one artifact, which would be confusing to
> someone who comes across the package on its own. For instance, if I go to
> "Build and testing”, which someone might do when reviewing the artifact,
> and it says "./gradlew :clients:client-python:build”, however that is not
> going to work in this artifact.
>
>
Yeah, the readme is more about how to build from scratch. This Python
package is a release package that can be used directly, no need to compile.
The README can be improved, but it's not a blocking thing here.



> Kind Regards,
> Justin
>
> 1. https://incubator.apache.org/policy/incubation.html#releases
>
>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> For Python release "apache_gravitino-0.6.0.tar.gz" version, as far as I
> know, Python doesn't support version like "0.6.0-incubating", so I only
> keep the 0.6.0 delibrately. I also refer to some other incubating projects
> like HugeGraph (https://pypi.org/project/hugegraph-python/#history), seems
> they also don't add the "incubating" in their version.

We must change this (easy enough to do with "svn mv") as all artifacts need ”incubating” in their name. See [1] "The release archive(s) MUST include the word "incubating" in the filename."

I’ll ask HugeGraph to also fix this.

Sure I can help out on the LICENSE and NOTICE issues. I’ve raised an issue for it.

> The local compile works for me. I'm not so sure about which file has the
> issues.

I’ll raise an issue with the details.

> It will be there when we have an official release.

It needs to be there while voting on the release. Several other incubating projects have been asked to fix this in recent times.

>> - The Python client README.md build instruction needs to be updated as
>> they assume it part of the main gravitino repo
>> 
>> 
> Python README.md already reflects the Python things including how to build
> Python package, can you please point out what specific issue it is?

Its context is outside of that one artifact, which would be confusing to someone who comes across the package on its own. For instance, if I go to "Build and testing”, which someone might do when reviewing the artifact, and it says "./gradlew :clients:client-python:build”, however that is not going to work in this artifact.

Kind Regards,
Justin

1. https://incubator.apache.org/policy/incubation.html#releases

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Jerry Shao <js...@apache.org>.
Can you please double-check this jar? I checked in my local environment, I
don't have that jar and folder in my local, this jar should be downloaded
only when running gradlew for the first time.

Best,
Jerry

Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 23:27写道：

> HI,
>
> Sorry, but I’m changing my vote to -1 (binding) as the gradle jar ended up
> in the src artifact, that is why the Rat plugin was failing.
>
> tar -xvf gravitino-0.6.0-incubating-src.tar.gz
> cd gravitino-0.6.0-incubating-src
> find . -name "*.jar" -print
>
> ./gradle/wrapper/gradle-wrapper.jar
>
> Kind Regards,
> Justin
>
>
>
>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
HI,

Sorry, but I’m changing my vote to -1 (binding) as the gradle jar ended up in the src artifact, that is why the Rat plugin was failing.

tar -xvf gravitino-0.6.0-incubating-src.tar.gz
cd gravitino-0.6.0-incubating-src
find . -name "*.jar" -print

./gradle/wrapper/gradle-wrapper.jar

Kind Regards,
Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by DanHua Wang <da...@datastrato.com>.
+1
I checked:
1) download links are OK
  2) checksum and signature are good
  3) build successfully with the src using JDK17 on my mac
  4) binary package start service successfully

On Tue, Sep 3, 2024 at 1:22 PM Xun Liu <li...@apache.org> wrote:

> +1 binding, looks good to me. I checked: 1. the SHA 512 hash is correct; 2.
> LICENSE, NOTICE and README are included in the source package; 3. Build
> success on my laptop. Best regards,
> Xun Liu
>
> On Tue, Sep 3, 2024 at 12:03 PM Justin Mclean <ju...@classsoftware.com>
> wrote:
>
> > Hi,
> >
> > I rechecked the signatures/hashes, and they are correct, so still, +1
> > (binding) from me.
> >
> > Kind Regards,
> > Justin
>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Xun Liu <li...@apache.org>.
+1 binding, looks good to me. I checked: 1. the SHA 512 hash is correct; 2.
LICENSE, NOTICE and README are included in the source package; 3. Build
success on my laptop. Best regards,
Xun Liu

On Tue, Sep 3, 2024 at 12:03 PM Justin Mclean <ju...@classsoftware.com>
wrote:

> Hi,
>
> I rechecked the signatures/hashes, and they are correct, so still, +1
> (binding) from me.
>
> Kind Regards,
> Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

I rechecked the signatures/hashes, and they are correct, so still, +1 (binding) from me.

Kind Regards,
Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Minghuang Li <mc...@apache.org>.
Hi Jerry,

+1(binding) since I have rechecked the work!

I rechecked:
1) download links are OK (only dist not including Maven Staging repo)
2) checksum and signature are good
3) build successfully with the src using JDK17 (./graldew build) on my mac
4) the availability of binary package (Unpack and test the setuped process)

Best regards,
Minghuang Li

On 2024/09/02 18:29:14 Jerry Shao wrote:
> Hi all,
> 
> Due to the "tar" compatible issue I used on Mac (bsdtar) and Linux
> (gnutar). The Gravitino src package have some decompression and build
> issues, I have changed to use gnutar, rebuilt all the packages, and
> uploaded to the SVN (
> https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/).
> Please help to check again. Thanks
> 
> Best,
> Jerry
> 
> Justin Mclean <ju...@classsoftware.com> 于2024年9月2日周一 02:26写道：
> 
> > Hi,
> >
> > Thanks, Jerry, that looks good to me.
> >
> > Kind Regards,
> > Justin
> >
> > > On 2 Sep 2024, at 5:06 PM, Jerry Shao <js...@apache.org> wrote:
> > >
> > > Added KEYS to
> > > https://dist.apache.org/repos/dist/release/incubator/gravitino/
> > > Removed Gravitino Python package from
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/
> > ,
> > > as it should not be shipped via ASF mirror, should be shipped by Pypi.
> > >
> > > Best,
> > > Jerry
> > >
> > >
> > > Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 23:50写道：
> > >
> > >> Hi,
> > >>
> > >> Sorry, I've checked again on a clean download, and there is no
> > gradle.jar.
> > >> So I’m +1 (binding) as long as the artifact names all contain
> > incubating.
> > >>
> > >> I can still replicate the rat issue. Perhaps it’s a concurrency issue or
> > >> an order issue as rat seems to run quite late in the build process,
> > perhaps
> > >> after the gradle jar has been downloaded?
> > >>
> > >> Kind Regards,
> > >> Justin
> >
> >
>

Reply: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Yu Qi <yu...@gmail.com>.
+1(binding)

I checked:
  1) Download links are OK.
  2) Checksum and signature are good
  3) ASF header present in expected files
  4) All license and links (except the link https://incubator.apache.org/projects/ravitino.html in DISCLAIMER_WIP.txt) are OK.
  5) Build is okay on both MacOS(13.3) and Linux(6.1.102-111.182.amzn2023.x86_64)


发件人: Jerry Shao <js...@apache.org>
日期: 星期二, 2024年9月3日 02:29
收件人: dev@gravitino.apache.org <de...@gravitino.apache.org>
主题: Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5
Hi all,

Due to the "tar" compatible issue I used on Mac (bsdtar) and Linux
(gnutar). The Gravitino src package have some decompression and build
issues, I have changed to use gnutar, rebuilt all the packages, and
uploaded to the SVN (
https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/).
Please help to check again. Thanks

Best,
Jerry

Justin Mclean <ju...@classsoftware.com> 于2024年9月2日周一 02:26写道：

> Hi,
>
> Thanks, Jerry, that looks good to me.
>
> Kind Regards,
> Justin
>
> > On 2 Sep 2024, at 5:06 PM, Jerry Shao <js...@apache.org> wrote:
> >
> > Added KEYS to
> > https://dist.apache.org/repos/dist/release/incubator/gravitino/
> > Removed Gravitino Python package from
> >
> https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/
> ,
> > as it should not be shipped via ASF mirror, should be shipped by Pypi.
> >
> > Best,
> > Jerry
> >
> >
> > Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 23:50写道：
> >
> >> Hi,
> >>
> >> Sorry, I've checked again on a clean download, and there is no
> gradle.jar.
> >> So I’m +1 (binding) as long as the artifact names all contain
> incubating.
> >>
> >> I can still replicate the rat issue. Perhaps it’s a concurrency issue or
> >> an order issue as rat seems to run quite late in the build process,
> perhaps
> >> after the gradle jar has been downloaded?
> >>
> >> Kind Regards,
> >> Justin
>
>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Xiaojing Fang <xi...@datastrato.com>.
+1 binding,

1. rechecked the signature and hash.
2. build successfully on Mac and Linux.

On Tue, Sep 3, 2024 at 10:49 AM roryqi <ro...@apache.org> wrote:

> Docker image haven't been changed. So I vote +1 directly.
>
> Justin Mclean <ju...@classsoftware.com> 于2024年9月3日周二 10:05写道：
>
> > Hi Jerry,
> >
> > It's up to you as the release manager. Given the signature and hashes
> were
> > regenerated, it might be best to do so, but as you say, the content is
> > identical. It would probably be OK if people who voted just rechecked the
> > hashes/signatures.
> >
> > Kind Regards,
> > Justin
>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by roryqi <ro...@apache.org>.
Docker image haven't been changed. So I vote +1 directly.

Justin Mclean <ju...@classsoftware.com> 于2024年9月3日周二 10:05写道：

> Hi Jerry,
>
> It's up to you as the release manager. Given the signature and hashes were
> regenerated, it might be best to do so, but as you say, the content is
> identical. It would probably be OK if people who voted just rechecked the
> hashes/signatures.
>
> Kind Regards,
> Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi Jerry,

It's up to you as the release manager. Given the signature and hashes were regenerated, it might be best to do so, but as you say, the content is identical. It would probably be OK if people who voted just rechecked the hashes/signatures.

Kind Regards,
Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Jerry Shao <js...@apache.org>.
Hi Justin,

There's no content change, and the commit id is not changed, only
repackaging and re-uploading to the SVN, nothing else changed. Shall we
make a new RC?

Best,
Jerry


Justin Mclean <ju...@classsoftware.com> 于2024年9月2日周一 15:35写道：

> Hi,
>
> Wouldn’t it be best to make a new RC6 as I assume the checksums have
> changed? Has anything else changed in the content of the artefacts other
> than repackaging?
>
> Kind Regards,
> Justin
>
> > On 3 Sep 2024, at 4:29 AM, Jerry Shao <js...@apache.org> wrote:
> >
> > Hi all,
> >
> > Due to the "tar" compatible issue I used on Mac (bsdtar) and Linux
> > (gnutar). The Gravitino src package have some decompression and build
> > issues, I have changed to use gnutar, rebuilt all the packages, and
> > uploaded to the SVN (
> >
> https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/
> ).
> > Please help to check again. Thanks
> >
> > Best,
> > Jerry
> >
> > Justin Mclean <ju...@classsoftware.com> 于2024年9月2日周一 02:26写道：
> >
> >> Hi,
> >>
> >> Thanks, Jerry, that looks good to me.
> >>
> >> Kind Regards,
> >> Justin
> >>
> >>> On 2 Sep 2024, at 5:06 PM, Jerry Shao <js...@apache.org> wrote:
> >>>
> >>> Added KEYS to
> >>> https://dist.apache.org/repos/dist/release/incubator/gravitino/
> >>> Removed Gravitino Python package from
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/
> >> ,
> >>> as it should not be shipped via ASF mirror, should be shipped by Pypi.
> >>>
> >>> Best,
> >>> Jerry
> >>>
> >>>
> >>> Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 23:50写道：
> >>>
> >>>> Hi,
> >>>>
> >>>> Sorry, I've checked again on a clean download, and there is no
> >> gradle.jar.
> >>>> So I’m +1 (binding) as long as the artifact names all contain
> >> incubating.
> >>>>
> >>>> I can still replicate the rat issue. Perhaps it’s a concurrency issue
> or
> >>>> an order issue as rat seems to run quite late in the build process,
> >> perhaps
> >>>> after the gradle jar has been downloaded?
> >>>>
> >>>> Kind Regards,
> >>>> Justin
> >>
> >>
>
>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Wouldn’t it be best to make a new RC6 as I assume the checksums have changed? Has anything else changed in the content of the artefacts other than repackaging?

Kind Regards,
Justin

> On 3 Sep 2024, at 4:29 AM, Jerry Shao <js...@apache.org> wrote:
> 
> Hi all,
> 
> Due to the "tar" compatible issue I used on Mac (bsdtar) and Linux
> (gnutar). The Gravitino src package have some decompression and build
> issues, I have changed to use gnutar, rebuilt all the packages, and
> uploaded to the SVN (
> https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/).
> Please help to check again. Thanks
> 
> Best,
> Jerry
> 
> Justin Mclean <ju...@classsoftware.com> 于2024年9月2日周一 02:26写道：
> 
>> Hi,
>> 
>> Thanks, Jerry, that looks good to me.
>> 
>> Kind Regards,
>> Justin
>> 
>>> On 2 Sep 2024, at 5:06 PM, Jerry Shao <js...@apache.org> wrote:
>>> 
>>> Added KEYS to
>>> https://dist.apache.org/repos/dist/release/incubator/gravitino/
>>> Removed Gravitino Python package from
>>> 
>> https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/
>> ,
>>> as it should not be shipped via ASF mirror, should be shipped by Pypi.
>>> 
>>> Best,
>>> Jerry
>>> 
>>> 
>>> Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 23:50写道：
>>> 
>>>> Hi,
>>>> 
>>>> Sorry, I've checked again on a clean download, and there is no
>> gradle.jar.
>>>> So I’m +1 (binding) as long as the artifact names all contain
>> incubating.
>>>> 
>>>> I can still replicate the rat issue. Perhaps it’s a concurrency issue or
>>>> an order issue as rat seems to run quite late in the build process,
>> perhaps
>>>> after the gradle jar has been downloaded?
>>>> 
>>>> Kind Regards,
>>>> Justin
>> 
>>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Jerry Shao <js...@apache.org>.
Hi all,

Due to the "tar" compatible issue I used on Mac (bsdtar) and Linux
(gnutar). The Gravitino src package have some decompression and build
issues, I have changed to use gnutar, rebuilt all the packages, and
uploaded to the SVN (
https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/).
Please help to check again. Thanks

Best,
Jerry

Justin Mclean <ju...@classsoftware.com> 于2024年9月2日周一 02:26写道：

> Hi,
>
> Thanks, Jerry, that looks good to me.
>
> Kind Regards,
> Justin
>
> > On 2 Sep 2024, at 5:06 PM, Jerry Shao <js...@apache.org> wrote:
> >
> > Added KEYS to
> > https://dist.apache.org/repos/dist/release/incubator/gravitino/
> > Removed Gravitino Python package from
> >
> https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/
> ,
> > as it should not be shipped via ASF mirror, should be shipped by Pypi.
> >
> > Best,
> > Jerry
> >
> >
> > Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 23:50写道：
> >
> >> Hi,
> >>
> >> Sorry, I've checked again on a clean download, and there is no
> gradle.jar.
> >> So I’m +1 (binding) as long as the artifact names all contain
> incubating.
> >>
> >> I can still replicate the rat issue. Perhaps it’s a concurrency issue or
> >> an order issue as rat seems to run quite late in the build process,
> perhaps
> >> after the gradle jar has been downloaded?
> >>
> >> Kind Regards,
> >> Justin
>
>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Thanks, Jerry, that looks good to me.

Kind Regards,
Justin

> On 2 Sep 2024, at 5:06 PM, Jerry Shao <js...@apache.org> wrote:
> 
> Added KEYS to
> https://dist.apache.org/repos/dist/release/incubator/gravitino/
> Removed Gravitino Python package from
> https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/,
> as it should not be shipped via ASF mirror, should be shipped by Pypi.
> 
> Best,
> Jerry
> 
> 
> Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 23:50写道：
> 
>> Hi,
>> 
>> Sorry, I've checked again on a clean download, and there is no gradle.jar.
>> So I’m +1 (binding) as long as the artifact names all contain incubating.
>> 
>> I can still replicate the rat issue. Perhaps it’s a concurrency issue or
>> an order issue as rat seems to run quite late in the build process, perhaps
>> after the gradle jar has been downloaded?
>> 
>> Kind Regards,
>> Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Jerry Shao <js...@apache.org>.
Added KEYS to
https://dist.apache.org/repos/dist/release/incubator/gravitino/
Removed Gravitino Python package from
https://dist.apache.org/repos/dist/dev/incubator/gravitino/v0.6.0-incubating-rc5/,
as it should not be shipped via ASF mirror, should be shipped by Pypi.

Best,
Jerry


Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 23:50写道：

> Hi,
>
> Sorry, I've checked again on a clean download, and there is no gradle.jar.
> So I’m +1 (binding) as long as the artifact names all contain incubating.
>
>  I can still replicate the rat issue. Perhaps it’s a concurrency issue or
> an order issue as rat seems to run quite late in the build process, perhaps
> after the gradle jar has been downloaded?
>
> Kind Regards,
> Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

Sorry, I've checked again on a clean download, and there is no gradle.jar. So I’m +1 (binding) as long as the artifact names all contain incubating.

 I can still replicate the rat issue. Perhaps it’s a concurrency issue or an order issue as rat seems to run quite late in the build process, perhaps after the gradle jar has been downloaded?

Kind Regards,
Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Saisai Shao <sa...@gmail.com>.
Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 23:09写道：

> Hi,
>
> > For Python release "apache_gravitino-0.6.0.tar.gz" version, as far as I
> > know, Python doesn't support version like "0.6.0-incubating", so I only
> > keep the 0.6.0 delibrately. I also refer to some other incubating
> projects
> > like HugeGraph (https://pypi.org/project/hugegraph-python/#history),
> seems
> > they also don't add the "incubating" in their version.
>
> For the last version of HugeGraph all release artefacts had the word
> incubating in them:
> https://dist.apache.org/repos/dist/release/incubator/hugegraph/1.3.0/


These are not python packages...

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

> For Python release "apache_gravitino-0.6.0.tar.gz" version, as far as I
> know, Python doesn't support version like "0.6.0-incubating", so I only
> keep the 0.6.0 delibrately. I also refer to some other incubating projects
> like HugeGraph (https://pypi.org/project/hugegraph-python/#history), seems
> they also don't add the "incubating" in their version.

For the last version of HugeGraph all release artefacts had the word incubating in them:
https://dist.apache.org/repos/dist/release/incubator/hugegraph/1.3.0/

(and the same with 1.2.0 and 1.0.0)

Their python page (https://pypi.org/project/hugegraph-python/) has some issues as it doesn't follow the guilelines here:
https://cwiki.apache.org/confluence/display/INCUBATOR/Distribution+Guidelines

Kind Regards,
Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,

For the Rat issue please see:
https://github.com/apache/gravitino/issues/4835

I just tried this again and could reproduce the error.

Kind Regards,
Justin

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Xiaojing Fang <xi...@datastrato.com>.
+1 binding

I have checked:
1.  The package signature and hash
2.  Could successful build the source code
3. LICENSE and NOTICE files exists in source and binary package
4. Do some basic tests
5. No extra binary in source package

I didn’t encounter rat problems and the issues Justin referred seems not
blocking , maybe we could improvement it in the next release.

On Mon, Sep 2, 2024 at 12:12 PM ShaoFeng Shi <sh...@apache.org> wrote:

> Hi Justin,
>
> "- Compile fails due to rat issues, but can compile from source (and test
> pass) with the addition of -x rat"
>
> I don't have this problem, I tried "./gradlew clean build -x test" and
> "./gradlew clean build" again, both are successful.
>
> What's the error in your rat report?
>
> Best regards,
>
> Shaofeng Shi 史少锋
> Apache Kylin PMC member,
> Apache Incubator PMC member,
> Email: shaofengshi@apache.org
>
>
>
>
>
>
> Jerry Shao <js...@apache.org> 于2024年9月2日周一 11:45写道：
>
> > Hi Justin, please see the inline comments.
> >
> > Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 19:39写道：
> >
> > > Hi,
> > >
> > > -1 (binding) as some files are misisng incubating in their names, but
> if
> > > those files are renamed, then +1 (binding)
> > >
> > > Several LICENSE and NOTICE files need updating, but that’s OK due to
> the
> > > WIP disclaimer.
> > >
> > > Testing on mocOS I checked:
> > > - Not all artifact names include incubating in them, e.g.
> > > apache_gravitino-0.6.0.tar.gz. This needs to be fixed, but there is no
> > need
> > > for a new RC or vote, just rename the files.
> > >
> >
> > For Python release "apache_gravitino-0.6.0.tar.gz" version, as far as I
> > know, Python doesn't support version like "0.6.0-incubating", so I only
> > keep the 0.6.0 delibrately. I also refer to some other incubating
> projects
> > like HugeGraph (https://pypi.org/project/hugegraph-python/#history),
> seems
> > they also don't add the "incubating" in their version.
> >
> >
> > > - Signatures and hashes are fine.
> > > - DISCLAIMER (WIP), NOTICE and LICENSE exist in all artifacts.
> > > - The LICENSE and NOTICE is incorrect for
> apache_gravitino-0.6.0.tar.gz,
> > > same with the licenses directory. The LICENSE and NOTICE files need to
> > > reflect what is in the release artifact, and it seems the binary
> LICENSE
> > > and NOTICE files for the Java release have been copied here. In this
> case
> > > of the stock LICENSE file, adding "MIT License Copyright (c) 2016
> Dhamu”
> > is
> > > all that is needed. BTW do we know what project this code comes from?
> > >
> >
> > Can you please help to work on this, I don't think I have enough time to
> > figure out all these version things one by one.
> >
> >
> > > - Similarly, the LICENSE and NOTICE files for
> > > gravitino-iceberg-rest-server-0.6.0-incubating-bin and
> > > gravitino-trino-connector-0.6.0-incubating need to be updated to
> reflect
> > > what is in them.
> > >
> >
> > Also for this, please help on this.
> >
> >
> > > - The main gravitino LICENSE is missing a license for TCPDS. I couldn't
> > > find out this data was licenced from a quick search. Do we know how the
> > > data is licensed?
> > >
> >
> > TPCDS data is generated by its tool, they're the random data (will be
> > varied in each execution). I don't find the license of TPC-DS tool, and
> not
> > sure about the data if it is OK with ASF license.
> >
> >
> > > - all ASF files have the correct header, although perhaps it could be
> > > added to some XML files.
> > >
> >
> > Can you please create an issue so we can add this?
> >
> >
> > > - No unexpected binary files in the source release
> > > - Compile fails due to rat issues, but can compile from source (and
> test
> > > pass) with the addition of -x rat
> > >
> >
> > The local compile works for me. I'm not so sure about which file has the
> > issues.
> >
> >
> > >
> > > Other minor issues:
> > > - The KEY file needs to be in
> > > https://dist.apache.org/repos/dist/release/incubator/gravitino/
> >
> >
> > It will be there when we have an official release.
> >
> >
> > >
> > > - I think gravitino-trino-connector-0.6.0-incubating.tar.gz should
> > include
> > > a “-bin” in the name as it’s not source code. Again, this can be
> renamed
> > > without a new RC or vote.
> > >
> >
> > Typically for trino connector, we don't add "-bin" in the name as well as
> > other connectors, it's a bit stranger as it is only a plugin, not a
> > standalone service.
> >
> >
> > > - Is the source code for gravitino-trino-connector-0.6.0-incubating and
> > > gravitino-iceberg-rest-server-0.6.0-incubating included in the release?
> > (I
> > > am asking this in case this comes up in the IPMC vote).
> > >
> >
> > They're all included in the Gravitino src package.
> >
> >
> > > - The rat test fails when building the source. The files it fails on
> are
> > > acceptable, except for possibly some XML files.
> > >
> >
> > Please point out the problems and create an issue. I don't see the issue
> in
> > my local build.
> >
> >
> > > - Do the “.github” and “.gitattributes” files need to be in the source
> > > release?
> > >
> >
> > I think they're also part of the source code, they can be shipped with
> > source release. If it is not required, we can do this in the next
> release.
> >
> >
> > > - The Python client README.md build instruction needs to be updated as
> > > they assume it part of the main gravitino repo
> > >
> > >
> > Python README.md already reflects the Python things including how to
> build
> > Python package, can you please point out what specific issue it is?
> >
> >
> >
> > >
> > > Kind Regards,
> > > Justin
> >
>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by ShaoFeng Shi <sh...@apache.org>.
Hi Justin,

"- Compile fails due to rat issues, but can compile from source (and test
pass) with the addition of -x rat"

I don't have this problem, I tried "./gradlew clean build -x test" and
"./gradlew clean build" again, both are successful.

What's the error in your rat report?

Best regards,

Shaofeng Shi 史少锋
Apache Kylin PMC member,
Apache Incubator PMC member,
Email: shaofengshi@apache.org






Jerry Shao <js...@apache.org> 于2024年9月2日周一 11:45写道：

> Hi Justin, please see the inline comments.
>
> Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 19:39写道：
>
> > Hi,
> >
> > -1 (binding) as some files are misisng incubating in their names, but if
> > those files are renamed, then +1 (binding)
> >
> > Several LICENSE and NOTICE files need updating, but that’s OK due to the
> > WIP disclaimer.
> >
> > Testing on mocOS I checked:
> > - Not all artifact names include incubating in them, e.g.
> > apache_gravitino-0.6.0.tar.gz. This needs to be fixed, but there is no
> need
> > for a new RC or vote, just rename the files.
> >
>
> For Python release "apache_gravitino-0.6.0.tar.gz" version, as far as I
> know, Python doesn't support version like "0.6.0-incubating", so I only
> keep the 0.6.0 delibrately. I also refer to some other incubating projects
> like HugeGraph (https://pypi.org/project/hugegraph-python/#history), seems
> they also don't add the "incubating" in their version.
>
>
> > - Signatures and hashes are fine.
> > - DISCLAIMER (WIP), NOTICE and LICENSE exist in all artifacts.
> > - The LICENSE and NOTICE is incorrect for apache_gravitino-0.6.0.tar.gz,
> > same with the licenses directory. The LICENSE and NOTICE files need to
> > reflect what is in the release artifact, and it seems the binary LICENSE
> > and NOTICE files for the Java release have been copied here. In this case
> > of the stock LICENSE file, adding "MIT License Copyright (c) 2016 Dhamu”
> is
> > all that is needed. BTW do we know what project this code comes from?
> >
>
> Can you please help to work on this, I don't think I have enough time to
> figure out all these version things one by one.
>
>
> > - Similarly, the LICENSE and NOTICE files for
> > gravitino-iceberg-rest-server-0.6.0-incubating-bin and
> > gravitino-trino-connector-0.6.0-incubating need to be updated to reflect
> > what is in them.
> >
>
> Also for this, please help on this.
>
>
> > - The main gravitino LICENSE is missing a license for TCPDS. I couldn't
> > find out this data was licenced from a quick search. Do we know how the
> > data is licensed?
> >
>
> TPCDS data is generated by its tool, they're the random data (will be
> varied in each execution). I don't find the license of TPC-DS tool, and not
> sure about the data if it is OK with ASF license.
>
>
> > - all ASF files have the correct header, although perhaps it could be
> > added to some XML files.
> >
>
> Can you please create an issue so we can add this?
>
>
> > - No unexpected binary files in the source release
> > - Compile fails due to rat issues, but can compile from source (and test
> > pass) with the addition of -x rat
> >
>
> The local compile works for me. I'm not so sure about which file has the
> issues.
>
>
> >
> > Other minor issues:
> > - The KEY file needs to be in
> > https://dist.apache.org/repos/dist/release/incubator/gravitino/
>
>
> It will be there when we have an official release.
>
>
> >
> > - I think gravitino-trino-connector-0.6.0-incubating.tar.gz should
> include
> > a “-bin” in the name as it’s not source code. Again, this can be renamed
> > without a new RC or vote.
> >
>
> Typically for trino connector, we don't add "-bin" in the name as well as
> other connectors, it's a bit stranger as it is only a plugin, not a
> standalone service.
>
>
> > - Is the source code for gravitino-trino-connector-0.6.0-incubating and
> > gravitino-iceberg-rest-server-0.6.0-incubating included in the release?
> (I
> > am asking this in case this comes up in the IPMC vote).
> >
>
> They're all included in the Gravitino src package.
>
>
> > - The rat test fails when building the source. The files it fails on are
> > acceptable, except for possibly some XML files.
> >
>
> Please point out the problems and create an issue. I don't see the issue in
> my local build.
>
>
> > - Do the “.github” and “.gitattributes” files need to be in the source
> > release?
> >
>
> I think they're also part of the source code, they can be shipped with
> source release. If it is not required, we can do this in the next release.
>
>
> > - The Python client README.md build instruction needs to be updated as
> > they assume it part of the main gravitino repo
> >
> >
> Python README.md already reflects the Python things including how to build
> Python package, can you please point out what specific issue it is?
>
>
>
> >
> > Kind Regards,
> > Justin
>

Re: [VOTE] Release Apache Gravitino 0.6.0-incubating RC5

Posted by Jerry Shao <js...@apache.org>.
Hi Justin, please see the inline comments.

Justin Mclean <ju...@classsoftware.com> 于2024年9月1日周日 19:39写道：

> Hi,
>
> -1 (binding) as some files are misisng incubating in their names, but if
> those files are renamed, then +1 (binding)
>
> Several LICENSE and NOTICE files need updating, but that’s OK due to the
> WIP disclaimer.
>
> Testing on mocOS I checked:
> - Not all artifact names include incubating in them, e.g.
> apache_gravitino-0.6.0.tar.gz. This needs to be fixed, but there is no need
> for a new RC or vote, just rename the files.
>

For Python release "apache_gravitino-0.6.0.tar.gz" version, as far as I
know, Python doesn't support version like "0.6.0-incubating", so I only
keep the 0.6.0 delibrately. I also refer to some other incubating projects
like HugeGraph (https://pypi.org/project/hugegraph-python/#history), seems
they also don't add the "incubating" in their version.


> - Signatures and hashes are fine.
> - DISCLAIMER (WIP), NOTICE and LICENSE exist in all artifacts.
> - The LICENSE and NOTICE is incorrect for apache_gravitino-0.6.0.tar.gz,
> same with the licenses directory. The LICENSE and NOTICE files need to
> reflect what is in the release artifact, and it seems the binary LICENSE
> and NOTICE files for the Java release have been copied here. In this case
> of the stock LICENSE file, adding "MIT License Copyright (c) 2016 Dhamu” is
> all that is needed. BTW do we know what project this code comes from?
>

Can you please help to work on this, I don't think I have enough time to
figure out all these version things one by one.


> - Similarly, the LICENSE and NOTICE files for
> gravitino-iceberg-rest-server-0.6.0-incubating-bin and
> gravitino-trino-connector-0.6.0-incubating need to be updated to reflect
> what is in them.
>

Also for this, please help on this.


> - The main gravitino LICENSE is missing a license for TCPDS. I couldn't
> find out this data was licenced from a quick search. Do we know how the
> data is licensed?
>

TPCDS data is generated by its tool, they're the random data (will be
varied in each execution). I don't find the license of TPC-DS tool, and not
sure about the data if it is OK with ASF license.


> - all ASF files have the correct header, although perhaps it could be
> added to some XML files.
>

Can you please create an issue so we can add this?


> - No unexpected binary files in the source release
> - Compile fails due to rat issues, but can compile from source (and test
> pass) with the addition of -x rat
>

The local compile works for me. I'm not so sure about which file has the
issues.


>
> Other minor issues:
> - The KEY file needs to be in
> https://dist.apache.org/repos/dist/release/incubator/gravitino/


It will be there when we have an official release.


>
> - I think gravitino-trino-connector-0.6.0-incubating.tar.gz should include
> a “-bin” in the name as it’s not source code. Again, this can be renamed
> without a new RC or vote.
>

Typically for trino connector, we don't add "-bin" in the name as well as
other connectors, it's a bit stranger as it is only a plugin, not a
standalone service.


> - Is the source code for gravitino-trino-connector-0.6.0-incubating and
> gravitino-iceberg-rest-server-0.6.0-incubating included in the release? (I
> am asking this in case this comes up in the IPMC vote).
>

They're all included in the Gravitino src package.


> - The rat test fails when building the source. The files it fails on are
> acceptable, except for possibly some XML files.
>

Please point out the problems and create an issue. I don't see the issue in
my local build.


> - Do the “.github” and “.gitattributes” files need to be in the source
> release?
>

I think they're also part of the source code, they can be shipped with
source release. If it is not required, we can do this in the next release.


> - The Python client README.md build instruction needs to be updated as
> they assume it part of the main gravitino repo
>
>
Python README.md already reflects the Python things including how to build
Python package, can you please point out what specific issue it is?



>
> Kind Regards,
> Justin