You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramachandran Krishnan <ra...@gmail.com> on 2023/03/09 03:40:27 UTC
Review Request 74342: RANGER-4126:Fetching getDBVersion in BaseDao class in the security-admin-web throws Exception for Oracle Database
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74342/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Bugs: RANGER-4126
https://issues.apache.org/jira/browse/RANGER-4126
Repository: ranger
Description
-------
The `getDBVersion` function in `BaseDao` in the security-admin-web module throws exception even for successful query execution for Oracle DB since it tries to cast an Array of Objects to a String.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 418557bcb
security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 8a13a1712
Diff: https://reviews.apache.org/r/74342/diff/1/
Testing
-------
Tested with Oracle DB and works fine
Thanks,
Ramachandran Krishnan
Re: Review Request 74342: RANGER-4126:Fetching getDBVersion in BaseDao class in the security-admin-web throws Exception for Oracle Database
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74342/#review225262
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java
Line 366 (original), 368 (patched)
<https://reviews.apache.org/r/74342/#comment313981>
Instead retrieving all columns (*), consider retrieving only column (banner):
query ="SELECT banner FROM v$version WHERE rownum<2";
dbVersion = (String) getEntityManager().createNativeQuery(query).getSingleResult();
- Madhan Neethiraj
On March 9, 2023, 3:40 a.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74342/
> -----------------------------------------------------------
>
> (Updated March 9, 2023, 3:40 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4126
> https://issues.apache.org/jira/browse/RANGER-4126
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The `getDBVersion` function in `BaseDao` in the security-admin-web module throws exception even for successful query execution for Oracle DB since it tries to cast an Array of Objects to a String.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 418557bcb
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 8a13a1712
>
>
> Diff: https://reviews.apache.org/r/74342/diff/1/
>
>
> Testing
> -------
>
> Tested with Oracle DB and works fine
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>
Re: Review Request 74342: RANGER-4126:Fetching getDBVersion in BaseDao class in the security-admin-web throws Exception for Oracle Database
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74342/#review225267
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 13, 2023, 2:50 p.m., Ramachandran Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74342/
> -----------------------------------------------------------
>
> (Updated March 13, 2023, 2:50 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4126
> https://issues.apache.org/jira/browse/RANGER-4126
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The `getDBVersion` function in `BaseDao` in the security-admin-web module throws exception even for successful query execution for Oracle DB since it tries to cast an Array of Objects to a String.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 418557bcb
> security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 8a13a1712
>
>
> Diff: https://reviews.apache.org/r/74342/diff/3/
>
>
> Testing
> -------
>
> Tested with Oracle DB and works fine
>
>
> Thanks,
>
> Ramachandran Krishnan
>
>
Re: Review Request 74342: RANGER-4126:Fetching getDBVersion in BaseDao class in the security-admin-web throws Exception for Oracle Database
Posted by Ramachandran Krishnan <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74342/
-----------------------------------------------------------
(Updated March 13, 2023, 2:50 p.m.)
Review request for ranger, Don Bosco Durai, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Bugs: RANGER-4126
https://issues.apache.org/jira/browse/RANGER-4126
Repository: ranger
Description
-------
The `getDBVersion` function in `BaseDao` in the security-admin-web module throws exception even for successful query execution for Oracle DB since it tries to cast an Array of Objects to a String.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 418557bcb
security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 8a13a1712
Diff: https://reviews.apache.org/r/74342/diff/3/
Changes: https://reviews.apache.org/r/74342/diff/2-3/
Testing
-------
Tested with Oracle DB and works fine
Thanks,
Ramachandran Krishnan
Re: Review Request 74342: RANGER-4126:Fetching getDBVersion in BaseDao class in the security-admin-web throws Exception for Oracle Database
Posted by Ramachandran Krishnan <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74342/
-----------------------------------------------------------
(Updated March 13, 2023, 2:33 p.m.)
Review request for ranger, Don Bosco Durai, Kirby Zhou, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Bugs: RANGER-4126
https://issues.apache.org/jira/browse/RANGER-4126
Repository: ranger
Description
-------
The `getDBVersion` function in `BaseDao` in the security-admin-web module throws exception even for successful query execution for Oracle DB since it tries to cast an Array of Objects to a String.
Diffs (updated)
-----
0001-RANGER-4126-Fetching-getDBVersion-in-BaseDao-class-i.patch PRE-CREATION
security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java 418557bcb
security-admin/src/main/java/org/apache/ranger/patch/cliutil/MetricUtil.java 8a13a1712
Diff: https://reviews.apache.org/r/74342/diff/2/
Changes: https://reviews.apache.org/r/74342/diff/1-2/
Testing
-------
Tested with Oracle DB and works fine
Thanks,
Ramachandran Krishnan