You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by "Michael Jumper (JIRA)" <ji...@apache.org> on 2017/03/24 20:50:41 UTC

[jira] [Comment Edited] (GUACAMOLE-249) Update RDP plugin support to 2.0.0 releases

    [ https://issues.apache.org/jira/browse/GUACAMOLE-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941110#comment-15941110 ] 

Michael Jumper edited comment on GUACAMOLE-249 at 3/24/17 8:49 PM:
-------------------------------------------------------------------

The prototype of most update handlers has been changed from returning {{void}} to FreeRDP's {{BOOL}}, with {{int}} parameters turning into {{UINT32}} and some pointers becoming {{const}}.

It looks like we'll have to write some interface layer to insulate guacamole-server from FreeRDP. I don't think it's possible to handle all these cases with purely {{#ifdef ... #endif}} while still keeping things maintainable. We'll have to define our own internal, minimal API which does most of everything, and then write various FreeRDP-version-specific interface layers and helper functions that abstract away all the API breakage.


was (Author: mike.jumper):
The prototype of most update handlers has been changed from returning {{void}} to FreeRDP's {{BOOL}}, with {{int}} parameters turning into {{UINT32}} and some pointers becoming to {{const}}.

It looks like we'll have to write some interface layer to insulate guacamole-server from FreeRDP. I don't think it's possible to handle all these cases with purely {{#ifdef ... #endif}} while still keeping things maintainable. We'll have to define our own internal, minimal API which does most of everything, and then write various FreeRDP-version-specific interface layers and helper functions that abstract away all the API breakage.

> Update RDP plugin support to 2.0.0 releases
> -------------------------------------------
>
>                 Key: GUACAMOLE-249
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-249
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: RDP
>            Reporter: Simone Caronni
>            Assignee: Michael Jumper
>
> The planets have aligned, after 2.5 years FreeRDP has released new snapshots:
> https://github.com/FreeRDP/FreeRDP/releases
> Thanks,
> --Simone



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)