You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/05/11 16:52:41 UTC
[GitHub] [hudi] nsivabalan opened a new pull request #2937: [DO_NO_MERGE] [WIP] Fixing namespace in hudi's table schema
nsivabalan opened a new pull request #2937:
URL: https://github.com/apache/hudi/pull/2937
## What is the purpose of the pull request
Trying to understand what all cases, we add namespace to schema.
As of now, got this data for COW table type.
Schema post processor enabled | Transformers | User provided target schema | Cur behavior|
-------------|----|----|-----|
yes|No|Yes| table schema's has no namespace. matches user provided schema|
yes|yes|No| had to make minor fix in post processor for NPE. with the fix, table schema has namespace in it. |
yes|yes|yes| table schema has namespace|
no|no|yes| table schema's has no namespace. matches user provided schema|
no|yes|yes|table schema's has no namespace. matches user provided schema|
no|yes|no| table's schema has namespace. |
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar closed pull request #2937: [DO_NO_MERGE] [WIP] Fixing namespace in hudi's table schema
Posted by GitBox <gi...@apache.org>.
vinothchandar closed pull request #2937:
URL: https://github.com/apache/hudi/pull/2937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] n3nash commented on pull request #2937: [DO_NO_MERGE] [WIP] Fixing namespace in hudi's table schema
Posted by GitBox <gi...@apache.org>.
n3nash commented on pull request #2937:
URL: https://github.com/apache/hudi/pull/2937#issuecomment-841601410
@nsivabalan So it looks like the user after all cannot go from `no-user-provided schema` to `user-provided-schema` or vice-versa right now since one of them adds namespace and other doesn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org