You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "heliang666s (via GitHub)" <gi...@apache.org> on 2024/10/16 06:24:03 UTC

[PR] 3.3 [dubbo-spi-extensions]

heliang666s opened a new pull request, #538:
URL: https://github.com/apache/dubbo-spi-extensions/pull/538

   ## What is the purpose of the change
   
   XXXXX
   
   ## Brief changelog
   
   XXXXX
   
   ## Verifying this change
   
   XXXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
   - [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before
     you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
     just this issue, without pulling in other changes - one PR resolves one issue.
   - [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit
     in the pull request should have a meaningful subject line and body.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
     exist. If the new feature or significant change is committed, please remember to add sample
     in [dubbo samples](https://github.com/apache/dubbo-samples) project.
   - [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure
     unit-test and integration-test pass.
   - [ ] If this contribution is large, please follow
     the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Resolved conflicts between 3.3 and master [dubbo-spi-extensions]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #538:
URL: https://github.com/apache/dubbo-spi-extensions/pull/538#issuecomment-2415961705

   ## [Codecov](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/538?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: Patch coverage is `0%` with `239 lines` in your changes missing coverage. Please review.
   > Project coverage is 0.00%. Comparing base [(`9b48975`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/9b48975e2e8c5d996bc25319fe7c93f0e3582be0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`aed8ed5`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/aed8ed576c1f47204ce7a2b4de54521f182fd410?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 176 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/538?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...ubbo/metadata/store/redis/RedisMetadataReport.java](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/538?src=pr&el=tree&filepath=dubbo-metadata-report-extensions%2Fdubbo-metadata-report-redis%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdubbo%2Fmetadata%2Fstore%2Fredis%2FRedisMetadataReport.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0LWV4dGVuc2lvbnMvZHViYm8tbWV0YWRhdGEtcmVwb3J0LXJlZGlzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9zdG9yZS9yZWRpcy9SZWRpc01ldGFkYXRhUmVwb3J0LmphdmE=) | 0.00% | [236 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...tadata/store/redis/RedisMetadataReportFactory.java](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/538?src=pr&el=tree&filepath=dubbo-metadata-report-extensions%2Fdubbo-metadata-report-redis%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdubbo%2Fmetadata%2Fstore%2Fredis%2FRedisMetadataReportFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHViYm8tbWV0YWRhdGEtcmVwb3J0LWV4dGVuc2lvbnMvZHViYm8tbWV0YWRhdGEtcmVwb3J0LXJlZGlzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9tZXRhZGF0YS9zdG9yZS9yZWRpcy9SZWRpc01ldGFkYXRhUmVwb3J0RmFjdG9yeS5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   | [...protobuf/support/GenericProtobufSerialization.java](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/538?src=pr&el=tree&filepath=dubbo-serialization-extensions%2Fdubbo-serialization-protobuf%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fdubbo%2Fcommon%2Fserialize%2Fprotobuf%2Fsupport%2FGenericProtobufSerialization.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZHViYm8tc2VyaWFsaXphdGlvbi1leHRlbnNpb25zL2R1YmJvLXNlcmlhbGl6YXRpb24tcHJvdG9idWYvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUvcHJvdG9idWYvc3VwcG9ydC9HZW5lcmljUHJvdG9idWZTZXJpYWxpemF0aW9uLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/538?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff             @@
   ##             master    #538      +/-   ##
   ===========================================
   - Coverage      0.27%   0.00%   -0.28%     
   ===========================================
     Files           299     525     +226     
     Lines         13730   17560    +3830     
     Branches       1737    2039     +302     
   ===========================================
   - Hits             38       0      -38     
   - Misses        13689   17560    +3871     
   + Partials          3       0       -3     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/538?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Resolved conflicts between 3.3 and master [dubbo-spi-extensions]

Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng merged PR #538:
URL: https://github.com/apache/dubbo-spi-extensions/pull/538


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


Re: [PR] Resolved conflicts between 3.3 and master [dubbo-spi-extensions]

Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng commented on PR #538:
URL: https://github.com/apache/dubbo-spi-extensions/pull/538#issuecomment-2416026625

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org