[GitHub] [skywalking] wu-sheng commented on a change in pull request #8789: Add template of Function

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #8789:
URL: https://github.com/apache/skywalking/pull/8789#discussion_r840680545



##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/Layer.java
##########
@@ -148,6 +150,14 @@ public static Layer valueOf(int value) {
         return layer;
     }
 
+    public static Layer nameOf(String name) {
+        Layer layer = DICTIONARY_NAME.get(name);
+        if (layer == null) {
+            return Layer.GENERAL;

Review comment:
       @arugal The `null as General` should move to handlers' sides to make forward compatibility. Not here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org