[GitHub] [iceberg] flyrain commented on a change in pull request #2520: Core: add key_metadata in ManifestFile

[GitBox <gi...@apache.org>]

flyrain commented on a change in pull request #2520:
URL: https://github.com/apache/iceberg/pull/2520#discussion_r625234029



##########
File path: core/src/main/java/org/apache/iceberg/GenericManifestFile.java
##########
@@ -58,6 +60,7 @@
   private Long existingRowsCount = null;
   private Long deletedRowsCount = null;
   private PartitionFieldSummary[] partitions = null;
+  private byte[] keyMetadata = null;

Review comment:
       Either way is OK to me as long as it is consistent here or across the project. To avoid getting back to this style issue again(we can work on more important things with that energy), I suggest to have this kind of style preference written down as a developer/reviewer guidance, so that at least we can refer to it. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org