You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/04 17:50:58 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8757:
improve performance for filter form selects
codecov-io edited a comment on issue #8757: improve performance for filter form selects
URL: https://github.com/apache/incubator-superset/pull/8757#issuecomment-561763343
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8757?src=pr&el=h1) Report
> Merging [#8757](https://codecov.io/gh/apache/incubator-superset/pull/8757?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/81e45acc43b7b7940dd2baee29fa3b6fcd3a0385?src=pr&el=desc) will **increase** coverage by `0.13%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8757?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8757 +/- ##
==========================================
+ Coverage 65.74% 65.87% +0.13%
==========================================
Files 483 483
Lines 24123 24123
Branches 2767 2767
==========================================
+ Hits 15860 15892 +32
+ Misses 8087 8055 -32
Partials 176 176
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8757?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8757/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvU2VsZWN0Q29udHJvbC5qc3g=) | `83.52% <ø> (ø)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8757/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.08% <0%> (+0.16%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8757/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `81.12% <0%> (+0.33%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8757/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `84.97% <0%> (+0.64%)` | :arrow_up: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/8757/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `66.66% <0%> (+9.99%)` | :arrow_up: |
| [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/8757/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5) | `94.48% <0%> (+10.23%)` | :arrow_up: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8757/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `83.33% <0%> (+27.77%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8757?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8757?src=pr&el=footer). Last update [81e45ac...3b789df](https://codecov.io/gh/apache/incubator-superset/pull/8757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org