You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "ocket8888 (via GitHub)" <gi...@apache.org> on 2023/02/01 21:13:41 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request, #7335: TPv2 fix login redirect
ocket8888 opened a new pull request, #7335:
URL: https://github.com/apache/trafficcontrol/pull/7335
Login redirect is broken because it can't handle query string parameters. This PR fixes it so unauthenticated users are directed back where they were trying to go after logging in.
<hr/>
## Which Traffic Control components are affected by this PR?
- Traffic Portal (experimental v2)
## What is the best way to verify this PR?
Assuming you have Traffic Ops running locally on port `6443`, run `ng serve` in the TPv2 directory, then open the URL http://localhost:4200/core/servers?search=test in a new private browsing context (or just any context where you aren't already authenticated). It should send you back to the login page, then after logging in that should take you to the servers table with the search field set to the string "text".
## If this is a bugfix, which Traffic Control versions contained the bug?
- master
## PR submission checklist
- [x] This PR uses existing tests
- [x] This PR doesn't need documentation
- [x] This PR doesn't need a CHANGELOG.md entry
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #7335: TPv2 fix login redirect
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on PR #7335:
URL: https://github.com/apache/trafficcontrol/pull/7335#issuecomment-1503467653
This is definitely still broken. Going to any page when authenticated will not bring you to the login screen. Not sure if login redirects are still broken as it's not properly moving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman merged pull request #7335: TPv2 fix login redirect
Posted by "zrhoffman (via GitHub)" <gi...@apache.org>.
zrhoffman merged PR #7335:
URL: https://github.com/apache/trafficcontrol/pull/7335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #7335: TPv2 fix login redirect
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on PR #7335:
URL: https://github.com/apache/trafficcontrol/pull/7335#issuecomment-1514896768
I think you are correct, the issue I was seeing occurs when you leave TP open and let the cookie expire naturally. It will then redirect the user to `https://{TPURL}`, which is just a blank screen with the sidebar shown as opposed to the login screen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7335: TPv2 fix login redirect
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on PR #7335:
URL: https://github.com/apache/trafficcontrol/pull/7335#issuecomment-1503960118
> Going to any page when authenticated will not bring you to the login screen.
... that's the correct behavior, though, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] shamrickus commented on pull request #7335: TPv2 fix login redirect
Posted by "shamrickus (via GitHub)" <gi...@apache.org>.
shamrickus commented on PR #7335:
URL: https://github.com/apache/trafficcontrol/pull/7335#issuecomment-1503969796
when _not_ authenticated, woops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on pull request #7335: TPv2 fix login redirect
Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on PR #7335:
URL: https://github.com/apache/trafficcontrol/pull/7335#issuecomment-1504237301
I can't reproduce that. I just opened it to http://localhost:4200/core/cdns in a new private browsing context and got redirected to login. What _doesn't_ work is actually redirecting afterwards. Since the core module isn't loaded until after authentication, there is no routing available under `/core/` at the time that the user logs in, so it can't navigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org