[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1447: [CELEBORN-546][FLINK] Use autoIncrement partitionId replace encode(mapId, attemptId) for generating partitionId

["waitinfuture (via GitHub)" <gi...@apache.org>]

waitinfuture commented on code in PR #1447:
URL: https://github.com/apache/incubator-celeborn/pull/1447#discussion_r1173757008


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala:
##########
@@ -957,22 +956,13 @@ class PushDataHandler extends BaseMessageHandler with Logging {
       callback: RpcResponseCallback,
       wrappedCallback: RpcResponseCallback): Boolean = {

Review Comment:
   wrappedCallback is not used. BTW, ```locationIsNull```, ```handleRpcRequestCore``` are only for MapPartition, I think better to refactor in the future.



##########
client-flink/flink-1.14/src/main/java/org/apache/celeborn/plugin/flink/RemoteShuffleMaster.java:
##########
@@ -238,18 +240,19 @@ public void close() throws Exception {
     ThreadUtils.shutdownExecutors(10, executor);
   }
 
-  private ShuffleTask encodeExternalShuffleTask(
+  private ShuffleResourceDescriptor genShuffleResourceDescriptor(

Review Comment:
   Will this method be called multiple times for the same (shuffleId, mapId, attemptId) ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org