You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/10 03:18:11 UTC
[GitHub] [apisix-dashboard] Firstsawyou opened a new pull request #461: Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file.
Firstsawyou opened a new pull request #461:
URL: https://github.com/apache/apisix-dashboard/pull/461
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
- Related issues
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #461: Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #461:
URL: https://github.com/apache/apisix-dashboard/pull/461#discussion_r486418283
##########
File path: .github/workflows/api_ci.yml
##########
@@ -54,6 +54,10 @@ jobs:
run: |
curl 127.0.0.1:9080
+ - name: run Makefile
Review comment:
Maybe License Checker should be an independent action file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #461: Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file.
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #461:
URL: https://github.com/apache/apisix-dashboard/pull/461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #461: Increase the checking of .conf and .toml files. And delete the redundant configuration of the ASF-Release.cfg file.
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #461:
URL: https://github.com/apache/apisix-dashboard/pull/461#discussion_r486418283
##########
File path: .github/workflows/api_ci.yml
##########
@@ -54,6 +54,10 @@ jobs:
run: |
curl 127.0.0.1:9080
+ - name: run Makefile
Review comment:
Maybe it would be better if License Checker should be an independent action file? but still looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org