[jira] Commented: (POOL-167) ObjectTimestampPair - fields tstamp and value "deprecation"

["Phil Steitz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/POOL-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12860533#action_12860533 ] 

Phil Steitz commented on POOL-167:
----------------------------------

What I meant in the deprecation comment was that *direct* access to the fields would no longer be possible in 2.0 - i.e., they will be private.   I am OK with edits to the comment making that clearer. 

> ObjectTimestampPair - fields tstamp and value "deprecation"
> -----------------------------------------------------------
>
>                 Key: POOL-167
>                 URL: https://issues.apache.org/jira/browse/POOL-167
>             Project: Commons Pool
>          Issue Type: Bug
>    Affects Versions: 1.5.4
>            Reporter: Sebb
>            Priority: Minor
>
> ObjectTimestampPair - fields tstamp and value are marked deprecated:
> "this field will be made private and final in version 2.0"
> Making the fields final is fine, however it does not seem possible to make the fields private without breaking a lot of existing code which needs read access to the fields.
> One way round this would be to add package-protected getter methods for the fields.
> This would allow the current code to be updated to avoid the deprecations.
> Does that seem like a sensible approach?
> If not, then at least the @deprecated comment ought to be changed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.