Re: [PR] fix: allow third-party backup provider plugins via configurable allowed list [cloudstack]

["yigitbasalma (via GitHub)" <gi...@apache.org>]

yigitbasalma commented on PR #13332:
URL: https://github.com/apache/cloudstack/pull/13332#issuecomment-4859082085

   @Pearl1594 Thank you for testing and the feedback.
   The root cause of the dashboard issue was that getBackupProvider() threw a CloudRuntimeException when the provider was not found, and getBackupStorageUsedStats() called it without any exception handling — causing the capacity dashboard to fail.
   This PR now includes two fixes:
   
   getBackupProvider() returns null instead of throwing when the provider is not found. This also makes the existing null check in BackupSyncTask.syncOutOfBandBackups() effective — it was previously unreachable because the exception was thrown before null could be returned.
   getBackupStorageUsedStats() now handles a null provider gracefully by returning an empty capacity object instead of propagating an exception to the dashboard.
   
   With these changes, configuring an invalid provider name will no longer crash the dashboard — it will simply show 0/0 backup storage capacity and log a warning.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org