You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Wim Deblauwe (JIRA)" <ji...@codehaus.org> on 2005/09/06 12:36:02 UTC

[jira] Created: (MPDASHBOARD-32) maven.dashboard.report.showempty property not honoured when using Maven 1.1b1

maven.dashboard.report.showempty property not honoured when using Maven 1.1b1
-----------------------------------------------------------------------------

         Key: MPDASHBOARD-32
         URL: http://jira.codehaus.org/browse/MPDASHBOARD-32
     Project: maven-dashboard-plugin
        Type: Bug
    Versions: 1.8    
 Environment: Maven 1.1beta1
Windows XP
 Reporter: Wim Deblauwe


When using the 'maven.dashboard.report.showempty' property, the dashboard overview still shows the empty reports. The problem seems to be with the isEmpty() call.

The orginal code is like this (in dashboard.jsl):

    <!-- Decide whether to display project data -->
    <j:set var="shallDisplay" value="true"/>
    <j:if test="${context.getVariable('maven.dashboard.report.showempty') == 'false'}">
      <x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
      <j:if test="${notEmptyElems.isEmpty() == 'true'}">
        <j:set var="shallDisplay" value="false"/>
      </j:if>
    </j:if>

It should be changed to this:

    <!-- Decide whether to display project data -->
    <j:set var="shallDisplay" value="true"/>
    <j:if test="${context.getVariable('maven.dashboard.report.showempty') == 'false'}">
      <x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
      <j:if test="${empty(notEmptyElems)}">    <!-- THIS LINE CHANGED -->
        <j:set var="shallDisplay" value="false"/>
      </j:if>
    </j:if>

I tested this and it works fine with my little change.

regards,

Wim

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

[jira] Closed: (MPDASHBOARD-32) maven.dashboard.report.showempty property not honoured when using Maven 1.1b1

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPDASHBOARD-32?page=all ]
     
Lukas Theussl closed MPDASHBOARD-32:
------------------------------------

     Resolution: Fixed
    Fix Version: 1.9

> maven.dashboard.report.showempty property not honoured when using Maven 1.1b1
> -----------------------------------------------------------------------------
>
>          Key: MPDASHBOARD-32
>          URL: http://jira.codehaus.org/browse/MPDASHBOARD-32
>      Project: maven-dashboard-plugin
>         Type: Bug

>     Versions: 1.8
>  Environment: Maven 1.1beta1
> Windows XP
>     Reporter: Wim Deblauwe
>      Fix For: 1.9

>
>
> When using the 'maven.dashboard.report.showempty' property, the dashboard overview still shows the empty reports. The problem seems to be with the isEmpty() call.
> The orginal code is like this (in dashboard.jsl):
>     <!-- Decide whether to display project data -->
>     <j:set var="shallDisplay" value="true"/>
>     <j:if test="${context.getVariable('maven.dashboard.report.showempty') == 'false'}">
>       <x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
>       <j:if test="${notEmptyElems.isEmpty() == 'true'}">
>         <j:set var="shallDisplay" value="false"/>
>       </j:if>
>     </j:if>
> It should be changed to this:
>     <!-- Decide whether to display project data -->
>     <j:set var="shallDisplay" value="true"/>
>     <j:if test="${context.getVariable('maven.dashboard.report.showempty') == 'false'}">
>       <x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
>       <j:if test="${empty(notEmptyElems)}">    <!-- THIS LINE CHANGED -->
>         <j:set var="shallDisplay" value="false"/>
>       </j:if>
>     </j:if>
> I tested this and it works fine with my little change.
> regards,
> Wim

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org