[GitHub] [kafka] wcarlson5 commented on a diff in pull request #14145: KAFKA-10199: Change to RUNNING if no pending task to recycle exist

["wcarlson5 (via GitHub)" <gi...@apache.org>]

wcarlson5 commented on code in PR #14145:
URL: https://github.com/apache/kafka/pull/14145#discussion_r1283451009


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java:
##########
@@ -114,6 +114,11 @@ public void addPendingTaskToRecycle(final TaskId taskId, final Set<TopicPartitio
         pendingUpdateActions.put(taskId, PendingUpdateAction.createRecycleTask(inputPartitions));
     }
 
+    @Override
+    public boolean pendingTasksToRecycleExist() {

Review Comment:
   super nit: This name sounds like its should return a list of tasks that are pending to recycle. Maybe add an `is` at the the front or something? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org