You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/03/17 22:49:29 UTC

[GitHub] [hudi] yihua opened a new pull request, #8226: [MINOR] Replace format `org.apache.hudi` with `hudi`

yihua opened a new pull request, #8226:
URL: https://github.com/apache/hudi/pull/8226

   ### Change Logs
   
   HUDI-372 (#1054) adds support for the short name `"hudi"` in Spark Datasource read and write (`df.write.format("hudi")`, `df.read.format("hudi")`).  All places should use "hudi" with `format()` now.
   
   ### Impact
   
   None.  Code clean-up.
   
   ### Risk level
   
   none
   
   ### Documentation Update
   
   N/A
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #8226: [HUDI-5951] Replace format `org.apache.hudi` with short name `hudi` in Spark Datasource

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8226:
URL: https://github.com/apache/hudi/pull/8226#issuecomment-1480687911

   > The change looks good but can you check why the tests are failing?
   
   Yes, I'm going to check the CI failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8226: [HUDI-5951] Replace format `org.apache.hudi` with short name `hudi` in Spark Datasource

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8226:
URL: https://github.com/apache/hudi/pull/8226#issuecomment-1474519204

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "27203c20ce6dc7f998109e8a2ee7b1c05201dc61",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15777",
       "triggerID" : "27203c20ce6dc7f998109e8a2ee7b1c05201dc61",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 27203c20ce6dc7f998109e8a2ee7b1c05201dc61 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15777) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8226: [HUDI-5951] Replace format `org.apache.hudi` with short name `hudi` in Spark Datasource

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8226:
URL: https://github.com/apache/hudi/pull/8226#issuecomment-1474650335

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "27203c20ce6dc7f998109e8a2ee7b1c05201dc61",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15777",
       "triggerID" : "27203c20ce6dc7f998109e8a2ee7b1c05201dc61",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 27203c20ce6dc7f998109e8a2ee7b1c05201dc61 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15777) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #8226: [HUDI-5951] Replace format `org.apache.hudi` with short name `hudi` in Spark Datasource

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8226:
URL: https://github.com/apache/hudi/pull/8226#issuecomment-1492581621

   I found out that if I replace `format("org.apache.hudi")` with `format("hudi")` in the test `TestCOWDataSource.testSaveAsTableInDifferentModes` fails with the following error (even without any production code changes):
   ```
   java.lang.IllegalArgumentException: Insert Overwrite Partition can not use bulk insert.
   	at org.apache.spark.sql.hudi.ProvidesHoodieConfig$$anonfun$9.apply(ProvidesHoodieConfig.scala:149)
   	at org.apache.spark.sql.hudi.ProvidesHoodieConfig$$anonfun$9.apply(ProvidesHoodieConfig.scala:145)
   ```
   
   We need to investigate this.  Supposedly, `format("hudi")` is the way to go and there shouldn't be any failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8226: [HUDI-5951] Replace format `org.apache.hudi` with short name `hudi` in Spark Datasource

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8226:
URL: https://github.com/apache/hudi/pull/8226#issuecomment-1474514890

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "27203c20ce6dc7f998109e8a2ee7b1c05201dc61",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "27203c20ce6dc7f998109e8a2ee7b1c05201dc61",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 27203c20ce6dc7f998109e8a2ee7b1c05201dc61 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org