You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@turbine.apache.org by Stephane Bailliez <sb...@apache.org> on 2002/02/22 00:20:39 UTC

[PATCH] Maven (huge bis)

Another huge patch zipped (405KB original) for Maven.

I missed rcs directory in the first one because it was a reserved keyword in my editor.

Changes:
- Convert all sources to Turbine coding style (brackets)
- Added missing if/else/for/while block
- a couple of import cleanup.
- Fix copyright year from 2001 to 2002.

Next step will probably be to fix naming coding style. (_ and such)

Attack plan once the above is done:
- wipe out the use of gnu.regexp in favor of Oro.
- use the code available in commons utils where possible. (StringUtils, NestableException..)
- clean up main() entry point in favor of JUnit testcase
- remove System.out in favor of ... (commons-logging ?)

In short: refactor what can be refactored

Cheers,

Stephane

Re: [PATCH] Maven (huge bis)

Posted by Johnny Cass <jo...@epiuse.com>.
Stephane Bailliez wrote:

> Another huge patch zipped (405KB original) for Maven.
> 
>  
> 
> I missed rcs directory in the first one because it was a reserved 
> keyword in my editor.
> 
>  
> 
> Changes:
> 
> - Convert all sources to Turbine coding style (brackets)
> 
> - Added missing if/else/for/while block
> 
> - a couple of import cleanup.
> 
> - Fix copyright year from 2001 to 2002.
> 
>  


Hi Stephane,

Are you using some kind of script to do all of this? I would very much 
like to do the same for one of our projects.

Thanks.
- Johnny


> 
> Next step will probably be to fix naming coding style. (_ and such)
> 
>  
> 
> Attack plan once the above is done:
> 
> - wipe out the use of gnu.regexp in favor of Oro.
> 
> - use the code available in commons utils where possible. (StringUtils, 
> NestableException..)
> 
> - clean up main() entry point in favor of JUnit testcase
> 
> - remove System.out in favor of ... (commons-logging ?)
> 
>  
> 
> In short: refactor what can be refactored
> 
>  
> 
> Cheers,
> 
>  
> 
> Stephane
> 
> 
> ------------------------------------------------------------------------
> 
> --
> To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
> For additional commands, e-mail: <ma...@jakarta.apache.org>
> 




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>