You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2020/01/18 08:17:42 UTC
[GitHub] [submarine] cchung100m opened a new pull request #156:
SUBMARINE-342. Upgrade Dockerfiles in Docs and dev-support folders to user
Ubuntu 18+
cchung100m opened a new pull request #156: SUBMARINE-342. Upgrade Dockerfiles in Docs and dev-support folders to user Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156
### What is this PR for?
Examine and upgrade all Dockefile to use a Ubuntu 18+ image for the newer version of TensorFlow (1.14+), it was built with glibc 2.25+ and no longer compatible with Ubuntu 16 images.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-342
### How should this be tested?
https://travis-ci.com/cchung100m/submarine/builds/145045790
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] asfgit closed pull request #156: SUBMARINE-342. Upgrade
Docker to use Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #156: SUBMARINE-342. Upgrade Docker to use Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #156: SUBMARINE-342.
Upgrade Dockerfiles in Docs and dev-support folders to user Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #156: SUBMARINE-342. Upgrade Dockerfiles in Docs and dev-support folders to user Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156#issuecomment-575884132
hi @cchung100m thank you improving the submarine.
I have 2 questions:
1. The title of PR is too long, I think it would be better to change to `Upgrade Docker to user Ubuntu 18+`
2. Because the submarine integrated travis has not yet checked docker, this part of your modification still relies on manual inspection. Can you provide the modified execution effect of each dockerfile? It can be a screenshot of the system operation. If the results are difficult to show, please explain.
Thanks again for your contribution!
:-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] jojochuang commented on issue #156: SUBMARINE-342.
Upgrade Docker to user Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #156: SUBMARINE-342. Upgrade Docker to user Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156#issuecomment-576522278
Just a nit: please change the commit message from "to user Ubuntu" to "to use Ubuntu" upon merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] tangzhankun commented on issue #156: SUBMARINE-342.
Upgrade Docker to user Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
tangzhankun commented on issue #156: SUBMARINE-342. Upgrade Docker to user Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156#issuecomment-576200752
@cchung100m Thanks for the patch! It looks good to me. The basic test steps can be done through the mini-submarine.
1. Change the TensorFlow version here: https://github.com/apache/submarine/blob/master/dev-support/mini-submarine/submarine/build_python_virtual_env.sh#L23
2. Build the mini-submarine locally and run the minist example following this doc:
https://github.com/apache/submarine/tree/master/dev-support/mini-submarine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] cchung100m commented on issue #156: SUBMARINE-342.
Upgrade Dockerfiles in Docs and dev-support folders to user Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
cchung100m commented on issue #156: SUBMARINE-342. Upgrade Dockerfiles in Docs and dev-support folders to user Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156#issuecomment-575886460
Hi @liuxunorg
Thanks for the review, I would add the screenshots of the modified execution effect of each dockerfile, later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #156: SUBMARINE-342.
Upgrade Docker to use Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #156: SUBMARINE-342. Upgrade Docker to use Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156#issuecomment-580245406
@cchung100m Thank you contribution.
Will merge if no more comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] oliverhu commented on issue #156: SUBMARINE-342.
Upgrade Docker to user Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
oliverhu commented on issue #156: SUBMARINE-342. Upgrade Docker to user Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156#issuecomment-575907425
+1 to @liuxunorg . @tangzhankun would you please provide some guidance for @cchung100m to validate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] cchung100m commented on issue #156: SUBMARINE-342.
Upgrade Docker to use Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
cchung100m commented on issue #156: SUBMARINE-342. Upgrade Docker to use Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156#issuecomment-577643899
Hi @liuxunorg @jojochuang @tangzhankun
Thanks for the review and suggestions. I have changed the TensorFlow version, built the mini-submarine locally and run the minist example. Please refer the screenshot and log as below:
log: https://gist.github.com/cchung100m/f668d78486728c7eba988fe02fa4eb05
<img width="1368" alt="螢幕快照 2020-01-23 下午7 28 21" src="https://user-images.githubusercontent.com/6762509/72981247-4fab0780-3e17-11ea-8b72-ec22359b5b3a.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] cchung100m commented on issue #156: SUBMARINE-342.
Upgrade Docker to use Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
cchung100m commented on issue #156: SUBMARINE-342. Upgrade Docker to use Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156#issuecomment-580570217
Hi @liuxunorg
Thanks for managing this PR. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on issue #156: SUBMARINE-342.
Upgrade Docker to user Ubuntu 18+
Posted by GitBox <gi...@apache.org>.
liuxunorg commented on issue #156: SUBMARINE-342. Upgrade Docker to user Ubuntu 18+
URL: https://github.com/apache/submarine/pull/156#issuecomment-576527438
> Just a nit: please change the commit message from "to user Ubuntu" to "to use Ubuntu" upon merge.
@cchung100m I help you change PR title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org