[GitHub] [superset] hughhhh commented on a change in pull request #17174: fix: use typing_extension instead

[GitBox <gi...@apache.org>]

hughhhh commented on a change in pull request #17174:
URL: https://github.com/apache/superset/pull/17174#discussion_r733082486



##########
File path: superset/config.py
##########
@@ -30,24 +30,15 @@
 import sys
 from collections import OrderedDict
 from datetime import date, timedelta
-from typing import (
-    Any,
-    Callable,
-    Dict,
-    List,
-    Literal,
-    Optional,
-    Type,
-    TYPE_CHECKING,
-    Union,
-)
+from typing import Any, Callable, Dict, List, Optional, Type, TYPE_CHECKING, Union

Review comment:
       yup
   ```
   ➜ python3.7
   Python 3.7.12 (default, Oct 13 2021, 06:53:03)
   [Clang 13.0.0 (clang-1300.0.29.3)] on darwin
   Type "help", "copyright", "credits" or "license" for more information.
   >>> from typing import (
       Any,
       Callable,
       Dict,
       List,
       Literal,
       Optional,
       Type,
       TYPE_CHECKING,
       Union,
   )
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   ImportError: cannot import name 'Literal' from 'typing' (/usr/local/Cellar/python@3.7/3.7.12_1/Frameworks/Python.framework/Versions/3.7/lib/python3.7/typing.py)
   >>> from typing import (
       Any,
       Callable,
       Dict,
       List,
       Optional,
       Type,
       TYPE_CHECKING,
       Union,
   )
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org