[GitHub] [geode] dschneider-pivotal opened pull request #3396: GEODE-6587: fix race in useFirst

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

useFirst had a race condition in which the connection it returned might not match the predicate. This is because the predicate was only checked while the connection will still not active. 
Now a recheck is done after activating the connection. If, after activation it does not match, the connection is added back on the end of the deque.

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3396 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on issue #3396: GEODE-6587: fix race in useFirst

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

It may cause connections that have been connected to a different server to move to the back of the queue. But since those connections have just been changed to a new server how active are they? No one has used them yet to send a message to their new server. Also we don't know where they were in the deque when we removed them. They could have been in the front, middle, or back. I would have preferred a solution that did not involve removing them but I think that would require bigger changes to the load conditioner and connection activation/passivation.

[ Full content available at: https://github.com/apache/geode/pull/3396 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on issue #3396: GEODE-6587: fix race in useFirst

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

The multipleClientLongTransactionsCanFailoverWithoutLosingOperations failure was also seen on another ci so it was not caused by this PR.

[ Full content available at: https://github.com/apache/geode/pull/3396 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal closed pull request #3396: GEODE-6587: fix race in useFirst

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by dschneider-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/3396 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org