You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/06/19 05:14:33 UTC

[GitHub] [skywalking] kezhenxu94 commented on issue #2908: Check disallowed imports in agent instrumentation classes

kezhenxu94 commented on issue #2908: Check disallowed imports in agent instrumentation classes
URL: https://github.com/apache/skywalking/pull/2908#issuecomment-503409164
 
 
   > Check style module is being removed, right?
   
   Yes, the module is just used for holding the `checkstyle.xml` file, and the file can be simply placed in the directory. After removing it, changing the checkstyle.xml doesn't require a deployment of that module.
   
   > And do I still need that scripts to check? Could we remove that?
   
   Removing it or not is both ok to me as long as it does no harm

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services