You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/10/01 08:50:14 UTC
Review Request 38916: AMBARI-13273 : Ambari stack changes to allow
Ranger Usersync to be installed on separate host
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38916/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
Bugs: AMBARI-13273
https://issues.apache.org/jira/browse/AMBARI-13273
Repository: ambari
Description
-------
Patch contains changes on ambari stacks to allow Ranger Usersync to be installed on separate host.
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 7c69e57
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py 85ac6f5
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 77e487f
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 7423e8d
Diff: https://reviews.apache.org/r/38916/diff/
Testing
-------
Unit test report:
----------------------------------------------------------------------
Ran 264 tests in 8.125s
OK
----------------------------------------------------------------------
Total run:838
Total errors:0
Total failures:0
OK
Process finished with exit code 0
Thanks,
Gautam Borad
Re: Review Request 38916: AMBARI-13273 : Ambari stack changes to allow
Ranger Usersync to be installed on separate host
Posted by Gautam Borad <gb...@gmail.com>.
> On Oct. 7, 2015, 4:34 p.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml, line 371
> > <https://reviews.apache.org/r/38916/diff/1/?file=1088260#file1088260line371>
> >
> > Instead of using a macro, The logic should be made part of stack advisor and we should keep using absolute value for the property for following reasons:
> > * we can gracefully handle upgrade scenario.
> > * We can use Service config version feature on ambari-web to compare it's actual absolute value with previous ones when needed
Jaimin, i think stack advisor wont help here since the requirement here is to derive the host name from the info already available from Ambari (the host where Ranger UserSync is running) and prefill it. Ideally we should leave it blank, but since we have the feature of Macros, we can use it here.
If we use stack advisor, 1] User will have to fill this value for each installation 2] If user decides to run against a different host, the stack advisor popup will come for each save asking user to use the host where its installed.
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38916/#review101782
-----------------------------------------------------------
On Oct. 1, 2015, 6:50 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38916/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 6:50 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13273
> https://issues.apache.org/jira/browse/AMBARI-13273
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes on ambari stacks to allow Ranger Usersync to be installed on separate host.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 7c69e57
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py 85ac6f5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 77e487f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 7423e8d
>
> Diff: https://reviews.apache.org/r/38916/diff/
>
>
> Testing
> -------
>
> Unit test report:
> ----------------------------------------------------------------------
> Ran 264 tests in 8.125s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38916: AMBARI-13273 : Ambari stack changes to allow
Ranger Usersync to be installed on separate host
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38916/#review101782
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml (line 371)
<https://reviews.apache.org/r/38916/#comment159272>
Instead of using a macro, The logic should be made part of stack advisor and we should keep using absolute value for the property for following reasons:
* we can gracefully handle upgrade scenario.
* We can use Service config version feature on ambari-web to compare it's actual absolute value with previous ones when needed
- Jaimin Jetly
On Oct. 1, 2015, 6:50 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38916/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 6:50 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13273
> https://issues.apache.org/jira/browse/AMBARI-13273
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes on ambari stacks to allow Ranger Usersync to be installed on separate host.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 7c69e57
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py 85ac6f5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 77e487f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 7423e8d
>
> Diff: https://reviews.apache.org/r/38916/diff/
>
>
> Testing
> -------
>
> Unit test report:
> ----------------------------------------------------------------------
> Ran 264 tests in 8.125s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38916: AMBARI-13273 : Ambari stack changes to allow
Ranger Usersync to be installed on separate host
Posted by Gautam Borad <gb...@gmail.com>.
> On Oct. 7, 2015, 5:07 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py, line 88
> > <https://reviews.apache.org/r/38916/diff/1/?file=1088257#file1088257line88>
> >
> > We should be careful here and only access an index in an array if we check that the array exists.
Changes available in latest patch
- Gautam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38916/#review101794
-----------------------------------------------------------
On Oct. 8, 2015, 1:04 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38916/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 1:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13273
> https://issues.apache.org/jira/browse/AMBARI-13273
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes on ambari stacks to allow Ranger Usersync to be installed on separate host.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 7c69e57
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py 85ac6f5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 77e487f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 96d6147
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json 2a40a46
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json f39df97
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 9bb1833
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json c04bdd1
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 977749c
>
> Diff: https://reviews.apache.org/r/38916/diff/
>
>
> Testing
> -------
>
> Unit test report:
> ----------------------------------------------------------------------
> Ran 264 tests in 8.125s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38916: AMBARI-13273 : Ambari stack changes to allow
Ranger Usersync to be installed on separate host
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38916/#review101794
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py (line 88)
<https://reviews.apache.org/r/38916/#comment159281>
We should be careful here and only access an index in an array if we check that the array exists.
- Alejandro Fernandez
On Oct. 1, 2015, 6:50 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38916/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 6:50 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13273
> https://issues.apache.org/jira/browse/AMBARI-13273
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes on ambari stacks to allow Ranger Usersync to be installed on separate host.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 7c69e57
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py 85ac6f5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 77e487f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 7423e8d
>
> Diff: https://reviews.apache.org/r/38916/diff/
>
>
> Testing
> -------
>
> Unit test report:
> ----------------------------------------------------------------------
> Ran 264 tests in 8.125s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38916: AMBARI-13273 : Ambari stack changes to allow
Ranger Usersync to be installed on separate host
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38916/#review101940
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 8, 2015, 1:04 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38916/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 1:04 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
>
>
> Bugs: AMBARI-13273
> https://issues.apache.org/jira/browse/AMBARI-13273
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Patch contains changes on ambari stacks to allow Ranger Usersync to be installed on separate host.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 7c69e57
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py 85ac6f5
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 77e487f
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 96d6147
> ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json 2a40a46
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json f39df97
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 9bb1833
> ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json c04bdd1
> ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 977749c
>
> Diff: https://reviews.apache.org/r/38916/diff/
>
>
> Testing
> -------
>
> Unit test report:
> ----------------------------------------------------------------------
> Ran 264 tests in 8.125s
>
> OK
> ----------------------------------------------------------------------
> Total run:838
> Total errors:0
> Total failures:0
> OK
>
> Process finished with exit code 0
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 38916: AMBARI-13273 : Ambari stack changes to allow
Ranger Usersync to be installed on separate host
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38916/
-----------------------------------------------------------
(Updated Oct. 8, 2015, 1:04 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Mahadev Konar, Sumit Mohanty, Selvamohan Neethiraj, Velmurugan Periasamy, and Yusaku Sako.
Changes
-------
Updated changes of Alejandro Fernandez comment
Bugs: AMBARI-13273
https://issues.apache.org/jira/browse/AMBARI-13273
Repository: ambari
Description
-------
Patch contains changes on ambari stacks to allow Ranger Usersync to be installed on separate host.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py 7c69e57
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/service_check.py 85ac6f5
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py 77e487f
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml 96d6147
ambari-server/src/test/python/stacks/2.0.6/configs/ranger-namenode-start.json 2a40a46
ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-default.json f39df97
ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-secured.json 9bb1833
ambari-server/src/test/python/stacks/2.2/configs/ranger-admin-upgrade.json c04bdd1
ambari-server/src/test/python/stacks/2.2/configs/ranger-usersync-upgrade.json 977749c
Diff: https://reviews.apache.org/r/38916/diff/
Testing
-------
Unit test report:
----------------------------------------------------------------------
Ran 264 tests in 8.125s
OK
----------------------------------------------------------------------
Total run:838
Total errors:0
Total failures:0
OK
Process finished with exit code 0
Thanks,
Gautam Borad