You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/02/04 01:48:29 UTC

[GitHub] [incubator-pinot] fx19880617 commented on pull request #6537: Fix the issue in Pinot Spark ingestion job to fill missing scheme for input files

fx19880617 commented on pull request #6537:
URL: https://github.com/apache/incubator-pinot/pull/6537#issuecomment-772962402


   > It seems `getFileURI` method is defined in both `SegmentGenerationUtils` and `SegmentGenerationAndPushTaskGenerator` classes. Is it possible to unify them in one place?
   
   Good point, this utils is on pinot-core and pinot-ingestion-common modules right now.
   I think we can move it to pinot-common module ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org