You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by Aaron Suddjian <aa...@preset.io> on 2022/02/14 23:34:26 UTC
[VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Hi all,
I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
https://github.com/apache/superset/issues/17081
The vote will be open for at least 1 week or until the necessary number of
votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
Thank you all for your discussion and collaboration around this proposal.
--
Aaron Suddjian, Software Engineer at Preset
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by "Michael S. Molina" <mi...@gmail.com>.
+1 (binding)
> On Feb 15, 2022, at 4:29 AM, Ville Brofeldt <vi...@gmail.com> wrote:
>
> +1, really thrilled to finally get rid of some of that old deprecated code. Ville
>
>> On 15. Feb 2022, at 1.34, Aaron Suddjian <aa...@preset.io> wrote:
>>
>> Hi all,
>>
>> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
>> https://github.com/apache/superset/issues/17081
>>
>> The vote will be open for at least 1 week or until the necessary number of
>> votes are reached.
>>
>> Please vote accordingly:
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thank you all for your discussion and collaboration around this proposal.
>>
>> --
>> Aaron Suddjian, Software Engineer at Preset
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Ville Brofeldt <vi...@gmail.com>.
+1, really thrilled to finally get rid of some of that old deprecated code. Ville
> On 15. Feb 2022, at 1.34, Aaron Suddjian <aa...@preset.io> wrote:
>
> Hi all,
>
> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> https://github.com/apache/superset/issues/17081
>
> The vote will be open for at least 1 week or until the necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you all for your discussion and collaboration around this proposal.
>
> --
> Aaron Suddjian, Software Engineer at Preset
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Maxime Beauchemin <ma...@gmail.com>.
+1 binding
On Tue, 15 Feb 2022 at 09:55, Jiali Kuang <li...@preset.io> wrote:
> +1 binding
>
> On Tue, Feb 15, 2022 at 6:23 AM Diego Pucci <di...@gmail.com>
> wrote:
>
> > +1
> >
> > Il giorno mar 15 feb 2022 alle ore 15:23 Daniel Gaspar <
> > dpgaspar@apache.org>
> > ha scritto:
> >
> > > +1 binding
> > >
> > >
> > > On 2022/02/14 23:34:26 Aaron Suddjian wrote:
> > > > Hi all,
> > > >
> > > > I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> > > > https://github.com/apache/superset/issues/17081
> > > >
> > > > The vote will be open for at least 1 week or until the necessary
> number
> > > of
> > > > votes are reached.
> > > >
> > > > Please vote accordingly:
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > Thank you all for your discussion and collaboration around this
> > proposal.
> > > >
> > > > --
> > > > Aaron Suddjian, Software Engineer at Preset
> > > >
> > >
> >
>
>
> --
> *Lily Kuang*
> Full Stack Engineer
> Preset | https://preset.io
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Jiali Kuang <li...@preset.io>.
+1 binding
On Tue, Feb 15, 2022 at 6:23 AM Diego Pucci <di...@gmail.com> wrote:
> +1
>
> Il giorno mar 15 feb 2022 alle ore 15:23 Daniel Gaspar <
> dpgaspar@apache.org>
> ha scritto:
>
> > +1 binding
> >
> >
> > On 2022/02/14 23:34:26 Aaron Suddjian wrote:
> > > Hi all,
> > >
> > > I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> > > https://github.com/apache/superset/issues/17081
> > >
> > > The vote will be open for at least 1 week or until the necessary number
> > of
> > > votes are reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thank you all for your discussion and collaboration around this
> proposal.
> > >
> > > --
> > > Aaron Suddjian, Software Engineer at Preset
> > >
> >
>
--
*Lily Kuang*
Full Stack Engineer
Preset | https://preset.io
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Diego Pucci <di...@gmail.com>.
+1
Il giorno mar 15 feb 2022 alle ore 15:23 Daniel Gaspar <dp...@apache.org>
ha scritto:
> +1 binding
>
>
> On 2022/02/14 23:34:26 Aaron Suddjian wrote:
> > Hi all,
> >
> > I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> > https://github.com/apache/superset/issues/17081
> >
> > The vote will be open for at least 1 week or until the necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you all for your discussion and collaboration around this proposal.
> >
> > --
> > Aaron Suddjian, Software Engineer at Preset
> >
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Daniel Gaspar <dp...@apache.org>.
+1 binding
On 2022/02/14 23:34:26 Aaron Suddjian wrote:
> Hi all,
>
> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> https://github.com/apache/superset/issues/17081
>
> The vote will be open for at least 1 week or until the necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you all for your discussion and collaboration around this proposal.
>
> --
> Aaron Suddjian, Software Engineer at Preset
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Evan Rusackas <ev...@preset.io>.
+1, binding!
Been waiting a long time for this, and super excited to see it gaining momentum. This release will also help us get better at planning and releasing major versions, supporting LTS branches, etc. Getting to 2.0 is exciting enough, but I’m equally excited about being able to march toward 3.0 and beyond.
Thanks,
-e-
Evan Rusackas
Preset | preset.io
On Feb 14, 2022, 4:34 PM -0700, Aaron Suddjian <aa...@preset.io>, wrote:
> Hi all,
>
> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> https://github.com/apache/superset/issues/17081
>
> The vote will be open for at least 1 week or until the necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you all for your discussion and collaboration around this proposal.
>
> --
> Aaron Suddjian, Software Engineer at Preset
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Grace Guo <gr...@airbnb.com.INVALID>.
+1 binding
- grace
> On Feb 14, 2022, at 3:34 PM, Aaron Suddjian <aa...@preset.io> wrote:
>
> Hi all,
>
> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> https://github.com/apache/superset/issues/17081
>
> The vote will be open for at least 1 week or until the necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you all for your discussion and collaboration around this proposal.
>
> --
> Aaron Suddjian, Software Engineer at Preset
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Phillip Kelley-Dotson <ph...@preset.io>.
+1
On Thu, Feb 17, 2022 at 10:31 AM Kamil Gabryjelski <
kamil.gabryjelski@gmail.com> wrote:
> +1
>
> wt., 15 lut 2022, 00:34 użytkownik Aaron Suddjian <aa...@preset.io>
> napisał:
>
> > Hi all,
> >
> > I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> > https://github.com/apache/superset/issues/17081
> >
> > The vote will be open for at least 1 week or until the necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you all for your discussion and collaboration around this proposal.
> >
> > --
> > Aaron Suddjian, Software Engineer at Preset
> >
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Kamil Gabryjelski <ka...@gmail.com>.
+1
wt., 15 lut 2022, 00:34 użytkownik Aaron Suddjian <aa...@preset.io> napisał:
> Hi all,
>
> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> https://github.com/apache/superset/issues/17081
>
> The vote will be open for at least 1 week or until the necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you all for your discussion and collaboration around this proposal.
>
> --
> Aaron Suddjian, Software Engineer at Preset
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Hugh Miles <hu...@gmail.com>.
+1
On Mon, Feb 14, 2022 at 3:34 PM, Aaron Suddjian <aa...@preset.io> wrote:
> Hi all,
>
> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> https://github.com/apache/superset/issues/17081
>
> The vote will be open for at least 1 week or until the necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you all for your discussion and collaboration around this proposal.
>
> --
> Aaron Suddjian, Software Engineer at Preset
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Beto Dealmeida <ro...@dealmeida.net.INVALID>.
Ah, makes sense. So we're getting rid of the feature flag — I thought we
were just changing the default value.
+1, binding.
On 2/14/22 4:36 PM, Aaron Suddjian wrote:
> Thanks for pointing that out Beto!
>
> The VERSIONED_EXPORT item should be thought of as permanently turning the
> flag on, removing the flag. This is desirable in cases where having the
> flag on has become the clearly superior experience, and where maintaining
> multiple options sustains an undue amount of tech debt. Some other flags in
> the list got the same treatment.
>
> Some of us had a meeting to quickly go through the list of proposals since
> there hadn't been much movement in the past months. We decided that it
> would be good to focus primarily on CLI and config changes. I'll post
> explanations for the ones considered unsuitable on the SIP.
>
> On Mon, Feb 14, 2022 at 3:41 PM Beto Dealmeida
> <ro...@dealmeida.net.invalid> wrote:
>
>> I have a comment on one item:
>>
>> # Remove old import/export code and turn on the VERSIONED_EXPORT flag by
>> default.
>>
>> We can't remove the old code and have the feature flag at the same time;
>> the old code is needed to turn the feature flag off.
>>
>> It also seems that many features were considered unsuitable without a
>> comment explaining why.
>>
>> On 2/14/22 3:34 PM, Aaron Suddjian wrote:
>>> Hi all,
>>>
>>> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
>>> https://github.com/apache/superset/issues/17081
>>>
>>> The vote will be open for at least 1 week or until the necessary number
>> of
>>> votes are reached.
>>>
>>> Please vote accordingly:
>>> [ ] +1 approve
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove with the reason
>>>
>>> Thank you all for your discussion and collaboration around this proposal.
>>>
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Yongjie <yo...@apache.org>.
+1 binding
On Tue, Feb 15, 2022 at 11:15 AM Tai Dupree <td...@gmail.com> wrote:
> +1 binding
>
> On Mon, Feb 14, 2022 at 6:33 PM Srinivasa Kadamati <sr...@preset.io>
> wrote:
>
> > +1 (binding)
> >
> > This is super exciting!
> >
> > On Mon, Feb 14, 2022 at 8:47 PM John Bodley <john.bodley@airbnb.com
> > .invalid>
> > wrote:
> >
> > > +1 (binding)
> > >
> > > Thanks Aaron for coordinating this.
> > >
> > > On Tue, Feb 15, 2022 at 2:07 PM Elizabeth Thompson <
> elizabeth@preset.io>
> > > wrote:
> > >
> > > > +1 Binding
> > > >
> > > > > On Feb 14, 2022, at 5:02 PM, Aaron Suddjian <aa...@preset.io>
> wrote:
> > > > >
> > > > > In the process of checking the list, I noticed that "Turn on
> > > > > SQLLAB_BACKEND_PERSISTENCE by default" ended up in the wrong
> column,
> > > and
> > > > > should be considered for inclusion. That's not removal of the
> feature
> > > > flag,
> > > > > just changing its default value.
> > > > >
> > > > > Thanks all, I think we can continue the vote unless there are
> further
> > > > > comments/concerns 😁
> > > > >
> > > > > On Mon, Feb 14, 2022 at 4:36 PM Aaron Suddjian <aa...@preset.io>
> > > wrote:
> > > > >
> > > > >> Thanks for pointing that out Beto!
> > > > >>
> > > > >> The VERSIONED_EXPORT item should be thought of as permanently
> > turning
> > > > the
> > > > >> flag on, removing the flag. This is desirable in cases where
> having
> > > the
> > > > >> flag on has become the clearly superior experience, and where
> > > > maintaining
> > > > >> multiple options sustains an undue amount of tech debt. Some other
> > > > flags in
> > > > >> the list got the same treatment.
> > > > >>
> > > > >> Some of us had a meeting to quickly go through the list of
> proposals
> > > > since
> > > > >> there hadn't been much movement in the past months. We decided
> that
> > it
> > > > >> would be good to focus primarily on CLI and config changes. I'll
> > post
> > > > >> explanations for the ones considered unsuitable on the SIP.
> > > > >>
> > > > >> On Mon, Feb 14, 2022 at 3:41 PM Beto Dealmeida
> > > > >> <ro...@dealmeida.net.invalid> wrote:
> > > > >>
> > > > >>> I have a comment on one item:
> > > > >>>
> > > > >>> # Remove old import/export code and turn on the VERSIONED_EXPORT
> > flag
> > > > by
> > > > >>> default.
> > > > >>>
> > > > >>> We can't remove the old code and have the feature flag at the
> same
> > > > time;
> > > > >>> the old code is needed to turn the feature flag off.
> > > > >>>
> > > > >>> It also seems that many features were considered unsuitable
> > without a
> > > > >>> comment explaining why.
> > > > >>>
> > > > >>> On 2/14/22 3:34 PM, Aaron Suddjian wrote:
> > > > >>>> Hi all,
> > > > >>>>
> > > > >>>> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking
> > > Changes:
> > > > >>>> https://github.com/apache/superset/issues/17081
> > > > >>>>
> > > > >>>> The vote will be open for at least 1 week or until the necessary
> > > > number
> > > > >>> of
> > > > >>>> votes are reached.
> > > > >>>>
> > > > >>>> Please vote accordingly:
> > > > >>>> [ ] +1 approve
> > > > >>>> [ ] +0 no opinion
> > > > >>>> [ ] -1 disapprove with the reason
> > > > >>>>
> > > > >>>> Thank you all for your discussion and collaboration around this
> > > > >>> proposal.
> > > > >>>>
> > > > >>>
> > > > >>
> > > > >>
> > > > >> --
> > > > >> Aaron Suddjian, Software Engineer at Preset
> > > > >>
> > > > >
> > > > >
> > > > > --
> > > > > Aaron Suddjian, Software Engineer at Preset
> > > >
> > > >
> > >
> >
>
>
> --
> -Tai Dupree
>
--
Best regards,
Yongjie
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Tai Dupree <td...@gmail.com>.
+1 binding
On Mon, Feb 14, 2022 at 6:33 PM Srinivasa Kadamati <sr...@preset.io> wrote:
> +1 (binding)
>
> This is super exciting!
>
> On Mon, Feb 14, 2022 at 8:47 PM John Bodley <john.bodley@airbnb.com
> .invalid>
> wrote:
>
> > +1 (binding)
> >
> > Thanks Aaron for coordinating this.
> >
> > On Tue, Feb 15, 2022 at 2:07 PM Elizabeth Thompson <el...@preset.io>
> > wrote:
> >
> > > +1 Binding
> > >
> > > > On Feb 14, 2022, at 5:02 PM, Aaron Suddjian <aa...@preset.io> wrote:
> > > >
> > > > In the process of checking the list, I noticed that "Turn on
> > > > SQLLAB_BACKEND_PERSISTENCE by default" ended up in the wrong column,
> > and
> > > > should be considered for inclusion. That's not removal of the feature
> > > flag,
> > > > just changing its default value.
> > > >
> > > > Thanks all, I think we can continue the vote unless there are further
> > > > comments/concerns 😁
> > > >
> > > > On Mon, Feb 14, 2022 at 4:36 PM Aaron Suddjian <aa...@preset.io>
> > wrote:
> > > >
> > > >> Thanks for pointing that out Beto!
> > > >>
> > > >> The VERSIONED_EXPORT item should be thought of as permanently
> turning
> > > the
> > > >> flag on, removing the flag. This is desirable in cases where having
> > the
> > > >> flag on has become the clearly superior experience, and where
> > > maintaining
> > > >> multiple options sustains an undue amount of tech debt. Some other
> > > flags in
> > > >> the list got the same treatment.
> > > >>
> > > >> Some of us had a meeting to quickly go through the list of proposals
> > > since
> > > >> there hadn't been much movement in the past months. We decided that
> it
> > > >> would be good to focus primarily on CLI and config changes. I'll
> post
> > > >> explanations for the ones considered unsuitable on the SIP.
> > > >>
> > > >> On Mon, Feb 14, 2022 at 3:41 PM Beto Dealmeida
> > > >> <ro...@dealmeida.net.invalid> wrote:
> > > >>
> > > >>> I have a comment on one item:
> > > >>>
> > > >>> # Remove old import/export code and turn on the VERSIONED_EXPORT
> flag
> > > by
> > > >>> default.
> > > >>>
> > > >>> We can't remove the old code and have the feature flag at the same
> > > time;
> > > >>> the old code is needed to turn the feature flag off.
> > > >>>
> > > >>> It also seems that many features were considered unsuitable
> without a
> > > >>> comment explaining why.
> > > >>>
> > > >>> On 2/14/22 3:34 PM, Aaron Suddjian wrote:
> > > >>>> Hi all,
> > > >>>>
> > > >>>> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking
> > Changes:
> > > >>>> https://github.com/apache/superset/issues/17081
> > > >>>>
> > > >>>> The vote will be open for at least 1 week or until the necessary
> > > number
> > > >>> of
> > > >>>> votes are reached.
> > > >>>>
> > > >>>> Please vote accordingly:
> > > >>>> [ ] +1 approve
> > > >>>> [ ] +0 no opinion
> > > >>>> [ ] -1 disapprove with the reason
> > > >>>>
> > > >>>> Thank you all for your discussion and collaboration around this
> > > >>> proposal.
> > > >>>>
> > > >>>
> > > >>
> > > >>
> > > >> --
> > > >> Aaron Suddjian, Software Engineer at Preset
> > > >>
> > > >
> > > >
> > > > --
> > > > Aaron Suddjian, Software Engineer at Preset
> > >
> > >
> >
>
--
-Tai Dupree
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Srinivasa Kadamati <sr...@preset.io>.
+1 (binding)
This is super exciting!
On Mon, Feb 14, 2022 at 8:47 PM John Bodley <jo...@airbnb.com.invalid>
wrote:
> +1 (binding)
>
> Thanks Aaron for coordinating this.
>
> On Tue, Feb 15, 2022 at 2:07 PM Elizabeth Thompson <el...@preset.io>
> wrote:
>
> > +1 Binding
> >
> > > On Feb 14, 2022, at 5:02 PM, Aaron Suddjian <aa...@preset.io> wrote:
> > >
> > > In the process of checking the list, I noticed that "Turn on
> > > SQLLAB_BACKEND_PERSISTENCE by default" ended up in the wrong column,
> and
> > > should be considered for inclusion. That's not removal of the feature
> > flag,
> > > just changing its default value.
> > >
> > > Thanks all, I think we can continue the vote unless there are further
> > > comments/concerns 😁
> > >
> > > On Mon, Feb 14, 2022 at 4:36 PM Aaron Suddjian <aa...@preset.io>
> wrote:
> > >
> > >> Thanks for pointing that out Beto!
> > >>
> > >> The VERSIONED_EXPORT item should be thought of as permanently turning
> > the
> > >> flag on, removing the flag. This is desirable in cases where having
> the
> > >> flag on has become the clearly superior experience, and where
> > maintaining
> > >> multiple options sustains an undue amount of tech debt. Some other
> > flags in
> > >> the list got the same treatment.
> > >>
> > >> Some of us had a meeting to quickly go through the list of proposals
> > since
> > >> there hadn't been much movement in the past months. We decided that it
> > >> would be good to focus primarily on CLI and config changes. I'll post
> > >> explanations for the ones considered unsuitable on the SIP.
> > >>
> > >> On Mon, Feb 14, 2022 at 3:41 PM Beto Dealmeida
> > >> <ro...@dealmeida.net.invalid> wrote:
> > >>
> > >>> I have a comment on one item:
> > >>>
> > >>> # Remove old import/export code and turn on the VERSIONED_EXPORT flag
> > by
> > >>> default.
> > >>>
> > >>> We can't remove the old code and have the feature flag at the same
> > time;
> > >>> the old code is needed to turn the feature flag off.
> > >>>
> > >>> It also seems that many features were considered unsuitable without a
> > >>> comment explaining why.
> > >>>
> > >>> On 2/14/22 3:34 PM, Aaron Suddjian wrote:
> > >>>> Hi all,
> > >>>>
> > >>>> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking
> Changes:
> > >>>> https://github.com/apache/superset/issues/17081
> > >>>>
> > >>>> The vote will be open for at least 1 week or until the necessary
> > number
> > >>> of
> > >>>> votes are reached.
> > >>>>
> > >>>> Please vote accordingly:
> > >>>> [ ] +1 approve
> > >>>> [ ] +0 no opinion
> > >>>> [ ] -1 disapprove with the reason
> > >>>>
> > >>>> Thank you all for your discussion and collaboration around this
> > >>> proposal.
> > >>>>
> > >>>
> > >>
> > >>
> > >> --
> > >> Aaron Suddjian, Software Engineer at Preset
> > >>
> > >
> > >
> > > --
> > > Aaron Suddjian, Software Engineer at Preset
> >
> >
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by John Bodley <jo...@airbnb.com.INVALID>.
+1 (binding)
Thanks Aaron for coordinating this.
On Tue, Feb 15, 2022 at 2:07 PM Elizabeth Thompson <el...@preset.io>
wrote:
> +1 Binding
>
> > On Feb 14, 2022, at 5:02 PM, Aaron Suddjian <aa...@preset.io> wrote:
> >
> > In the process of checking the list, I noticed that "Turn on
> > SQLLAB_BACKEND_PERSISTENCE by default" ended up in the wrong column, and
> > should be considered for inclusion. That's not removal of the feature
> flag,
> > just changing its default value.
> >
> > Thanks all, I think we can continue the vote unless there are further
> > comments/concerns 😁
> >
> > On Mon, Feb 14, 2022 at 4:36 PM Aaron Suddjian <aa...@preset.io> wrote:
> >
> >> Thanks for pointing that out Beto!
> >>
> >> The VERSIONED_EXPORT item should be thought of as permanently turning
> the
> >> flag on, removing the flag. This is desirable in cases where having the
> >> flag on has become the clearly superior experience, and where
> maintaining
> >> multiple options sustains an undue amount of tech debt. Some other
> flags in
> >> the list got the same treatment.
> >>
> >> Some of us had a meeting to quickly go through the list of proposals
> since
> >> there hadn't been much movement in the past months. We decided that it
> >> would be good to focus primarily on CLI and config changes. I'll post
> >> explanations for the ones considered unsuitable on the SIP.
> >>
> >> On Mon, Feb 14, 2022 at 3:41 PM Beto Dealmeida
> >> <ro...@dealmeida.net.invalid> wrote:
> >>
> >>> I have a comment on one item:
> >>>
> >>> # Remove old import/export code and turn on the VERSIONED_EXPORT flag
> by
> >>> default.
> >>>
> >>> We can't remove the old code and have the feature flag at the same
> time;
> >>> the old code is needed to turn the feature flag off.
> >>>
> >>> It also seems that many features were considered unsuitable without a
> >>> comment explaining why.
> >>>
> >>> On 2/14/22 3:34 PM, Aaron Suddjian wrote:
> >>>> Hi all,
> >>>>
> >>>> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> >>>> https://github.com/apache/superset/issues/17081
> >>>>
> >>>> The vote will be open for at least 1 week or until the necessary
> number
> >>> of
> >>>> votes are reached.
> >>>>
> >>>> Please vote accordingly:
> >>>> [ ] +1 approve
> >>>> [ ] +0 no opinion
> >>>> [ ] -1 disapprove with the reason
> >>>>
> >>>> Thank you all for your discussion and collaboration around this
> >>> proposal.
> >>>>
> >>>
> >>
> >>
> >> --
> >> Aaron Suddjian, Software Engineer at Preset
> >>
> >
> >
> > --
> > Aaron Suddjian, Software Engineer at Preset
>
>
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Elizabeth Thompson <el...@preset.io>.
+1 Binding
> On Feb 14, 2022, at 5:02 PM, Aaron Suddjian <aa...@preset.io> wrote:
>
> In the process of checking the list, I noticed that "Turn on
> SQLLAB_BACKEND_PERSISTENCE by default" ended up in the wrong column, and
> should be considered for inclusion. That's not removal of the feature flag,
> just changing its default value.
>
> Thanks all, I think we can continue the vote unless there are further
> comments/concerns 😁
>
> On Mon, Feb 14, 2022 at 4:36 PM Aaron Suddjian <aa...@preset.io> wrote:
>
>> Thanks for pointing that out Beto!
>>
>> The VERSIONED_EXPORT item should be thought of as permanently turning the
>> flag on, removing the flag. This is desirable in cases where having the
>> flag on has become the clearly superior experience, and where maintaining
>> multiple options sustains an undue amount of tech debt. Some other flags in
>> the list got the same treatment.
>>
>> Some of us had a meeting to quickly go through the list of proposals since
>> there hadn't been much movement in the past months. We decided that it
>> would be good to focus primarily on CLI and config changes. I'll post
>> explanations for the ones considered unsuitable on the SIP.
>>
>> On Mon, Feb 14, 2022 at 3:41 PM Beto Dealmeida
>> <ro...@dealmeida.net.invalid> wrote:
>>
>>> I have a comment on one item:
>>>
>>> # Remove old import/export code and turn on the VERSIONED_EXPORT flag by
>>> default.
>>>
>>> We can't remove the old code and have the feature flag at the same time;
>>> the old code is needed to turn the feature flag off.
>>>
>>> It also seems that many features were considered unsuitable without a
>>> comment explaining why.
>>>
>>> On 2/14/22 3:34 PM, Aaron Suddjian wrote:
>>>> Hi all,
>>>>
>>>> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
>>>> https://github.com/apache/superset/issues/17081
>>>>
>>>> The vote will be open for at least 1 week or until the necessary number
>>> of
>>>> votes are reached.
>>>>
>>>> Please vote accordingly:
>>>> [ ] +1 approve
>>>> [ ] +0 no opinion
>>>> [ ] -1 disapprove with the reason
>>>>
>>>> Thank you all for your discussion and collaboration around this
>>> proposal.
>>>>
>>>
>>
>>
>> --
>> Aaron Suddjian, Software Engineer at Preset
>>
>
>
> --
> Aaron Suddjian, Software Engineer at Preset
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Aaron Suddjian <aa...@preset.io>.
In the process of checking the list, I noticed that "Turn on
SQLLAB_BACKEND_PERSISTENCE by default" ended up in the wrong column, and
should be considered for inclusion. That's not removal of the feature flag,
just changing its default value.
Thanks all, I think we can continue the vote unless there are further
comments/concerns 😁
On Mon, Feb 14, 2022 at 4:36 PM Aaron Suddjian <aa...@preset.io> wrote:
> Thanks for pointing that out Beto!
>
> The VERSIONED_EXPORT item should be thought of as permanently turning the
> flag on, removing the flag. This is desirable in cases where having the
> flag on has become the clearly superior experience, and where maintaining
> multiple options sustains an undue amount of tech debt. Some other flags in
> the list got the same treatment.
>
> Some of us had a meeting to quickly go through the list of proposals since
> there hadn't been much movement in the past months. We decided that it
> would be good to focus primarily on CLI and config changes. I'll post
> explanations for the ones considered unsuitable on the SIP.
>
> On Mon, Feb 14, 2022 at 3:41 PM Beto Dealmeida
> <ro...@dealmeida.net.invalid> wrote:
>
>> I have a comment on one item:
>>
>> # Remove old import/export code and turn on the VERSIONED_EXPORT flag by
>> default.
>>
>> We can't remove the old code and have the feature flag at the same time;
>> the old code is needed to turn the feature flag off.
>>
>> It also seems that many features were considered unsuitable without a
>> comment explaining why.
>>
>> On 2/14/22 3:34 PM, Aaron Suddjian wrote:
>> > Hi all,
>> >
>> > I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
>> > https://github.com/apache/superset/issues/17081
>> >
>> > The vote will be open for at least 1 week or until the necessary number
>> of
>> > votes are reached.
>> >
>> > Please vote accordingly:
>> > [ ] +1 approve
>> > [ ] +0 no opinion
>> > [ ] -1 disapprove with the reason
>> >
>> > Thank you all for your discussion and collaboration around this
>> proposal.
>> >
>>
>
>
> --
> Aaron Suddjian, Software Engineer at Preset
>
--
Aaron Suddjian, Software Engineer at Preset
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Aaron Suddjian <aa...@preset.io>.
Thanks for pointing that out Beto!
The VERSIONED_EXPORT item should be thought of as permanently turning the
flag on, removing the flag. This is desirable in cases where having the
flag on has become the clearly superior experience, and where maintaining
multiple options sustains an undue amount of tech debt. Some other flags in
the list got the same treatment.
Some of us had a meeting to quickly go through the list of proposals since
there hadn't been much movement in the past months. We decided that it
would be good to focus primarily on CLI and config changes. I'll post
explanations for the ones considered unsuitable on the SIP.
On Mon, Feb 14, 2022 at 3:41 PM Beto Dealmeida
<ro...@dealmeida.net.invalid> wrote:
> I have a comment on one item:
>
> # Remove old import/export code and turn on the VERSIONED_EXPORT flag by
> default.
>
> We can't remove the old code and have the feature flag at the same time;
> the old code is needed to turn the feature flag off.
>
> It also seems that many features were considered unsuitable without a
> comment explaining why.
>
> On 2/14/22 3:34 PM, Aaron Suddjian wrote:
> > Hi all,
> >
> > I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> > https://github.com/apache/superset/issues/17081
> >
> > The vote will be open for at least 1 week or until the necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thank you all for your discussion and collaboration around this proposal.
> >
>
--
Aaron Suddjian, Software Engineer at Preset
Re: [VOTE][SIP-74] Breaking Changes to include in Superset 2.0
Posted by Beto Dealmeida <ro...@dealmeida.net.INVALID>.
I have a comment on one item:
# Remove old import/export code and turn on the VERSIONED_EXPORT flag by
default.
We can't remove the old code and have the feature flag at the same time;
the old code is needed to turn the feature flag off.
It also seems that many features were considered unsuitable without a
comment explaining why.
On 2/14/22 3:34 PM, Aaron Suddjian wrote:
> Hi all,
>
> I'd like to call for a vote on SIP-74, Superset 2.0 Breaking Changes:
> https://github.com/apache/superset/issues/17081
>
> The vote will be open for at least 1 week or until the necessary number of
> votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thank you all for your discussion and collaboration around this proposal.
>