You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2019/12/02 22:06:39 UTC

[GitHub] [curator] shayshim commented on a change in pull request #334: [CURATOR-549] Support ZooKeeper 3.5.6 Persistent Recursive Watchers

shayshim commented on a change in pull request #334: [CURATOR-549] Support ZooKeeper 3.5.6 Persistent Recursive Watchers
URL: https://github.com/apache/curator/pull/334#discussion_r352884218
 
 

 ##########
 File path: curator-x-async/src/main/java/org/apache/curator/x/async/api/AsyncCuratorFrameworkDsl.java
 ##########
 @@ -112,4 +112,11 @@
      * @return builder object
      */
     AsyncRemoveWatchesBuilder removeWatches();
+
+    /**
+     * Start an add watch builder
+     *
+     * @return builder object
+     */
+    AsyncWatchBuilder addWatch();
 
 Review comment:
   Shouldn't addWatch() be named watchers(), line in CuratorFramwork, to be consistent with the naming?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services