You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jianxia Chen <jc...@pivotal.io> on 2016/04/05 23:54:13 UTC
Review Request 45780: GEODE-960 CI failure:
LocatorDUnitTest.testOneLocator failed with AssertionError
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45780/
-----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
Repository: geode
Description
-------
Increase the waiting time.
The bug is really hard to reproduce. By analyzing the stack trace and the code, it is likely the test does not give enough time to allow the change of coordinator, if the system is busy (e.g. GC)
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java b3cc86c
Diff: https://reviews.apache.org/r/45780/diff/
Testing
-------
Thanks,
Jianxia Chen
Re: Review Request 45780: GEODE-960 CI failure:
LocatorDUnitTest.testOneLocator failed with AssertionError
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45780/#review127426
-----------------------------------------------------------
Ship it!
Ship It!
- Bruce Schuchardt
On April 6, 2016, 6:28 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45780/
> -----------------------------------------------------------
>
> (Updated April 6, 2016, 6:28 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Increase the waiting time.
>
> The bug is really hard to reproduce. By analyzing the stack trace and the code, it is likely the test does not give enough time to allow the change of coordinator, if the system is busy (e.g. GC)
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java b3cc86c
>
> Diff: https://reviews.apache.org/r/45780/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 45780: GEODE-960 CI failure:
LocatorDUnitTest.testOneLocator failed with AssertionError
Posted by Jianxia Chen <jc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45780/
-----------------------------------------------------------
(Updated April 6, 2016, 6:28 p.m.)
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
Changes
-------
Decrease the default member-timeout, so that the test will take shorter time, also if the system is busy, the test will have relatively more time to change the coordinator.
Repository: geode
Description
-------
Increase the waiting time.
The bug is really hard to reproduce. By analyzing the stack trace and the code, it is likely the test does not give enough time to allow the change of coordinator, if the system is busy (e.g. GC)
Diffs (updated)
-----
geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java b3cc86c
Diff: https://reviews.apache.org/r/45780/diff/
Testing
-------
Thanks,
Jianxia Chen
Re: Review Request 45780: GEODE-960 CI failure:
LocatorDUnitTest.testOneLocator failed with AssertionError
Posted by Jianxia Chen <jc...@pivotal.io>.
> On April 6, 2016, 3:07 p.m., Bruce Schuchardt wrote:
> > Edin's idea was to decrease the member-timeout setting in the DistributedSystem settings. Did that not work? It would let the test finish faster than keeping the default member-timeout setting and increasing the wait-criterion timeout.
I am not sure whether the member-timeout properties actually works. I set it to 1000ms in the test. However, in the logs, the "[locator]" vm is still using the default 5000 member-timeout. Other vms [vm_0], [vm_1], [vm_2] and the test vm itself use the new 1000ms member-timeout.
- Jianxia
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45780/#review127336
-----------------------------------------------------------
On April 5, 2016, 9:54 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45780/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:54 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Increase the waiting time.
>
> The bug is really hard to reproduce. By analyzing the stack trace and the code, it is likely the test does not give enough time to allow the change of coordinator, if the system is busy (e.g. GC)
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java b3cc86c
>
> Diff: https://reviews.apache.org/r/45780/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 45780: GEODE-960 CI failure:
LocatorDUnitTest.testOneLocator failed with AssertionError
Posted by Bruce Schuchardt <bs...@pivotal.io>.
> On April 6, 2016, 3:07 p.m., Bruce Schuchardt wrote:
> > Edin's idea was to decrease the member-timeout setting in the DistributedSystem settings. Did that not work? It would let the test finish faster than keeping the default member-timeout setting and increasing the wait-criterion timeout.
>
> Jianxia Chen wrote:
> I am not sure whether the member-timeout properties actually works. I set it to 1000ms in the test. However, in the logs, the "[locator]" vm is still using the default 5000 member-timeout. Other vms [vm_0], [vm_1], [vm_2] and the test vm itself use the new 1000ms member-timeout.
That test should not be using the dunit locator so setting 1000ms in the locators created by the test should work okay. The dunit locator log entries are prefixed with "[locator]".
- Bruce
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45780/#review127336
-----------------------------------------------------------
On April 5, 2016, 9:54 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45780/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:54 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Increase the waiting time.
>
> The bug is really hard to reproduce. By analyzing the stack trace and the code, it is likely the test does not give enough time to allow the change of coordinator, if the system is busy (e.g. GC)
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java b3cc86c
>
> Diff: https://reviews.apache.org/r/45780/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>
Re: Review Request 45780: GEODE-960 CI failure:
LocatorDUnitTest.testOneLocator failed with AssertionError
Posted by Bruce Schuchardt <bs...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45780/#review127336
-----------------------------------------------------------
Edin's idea was to decrease the member-timeout setting in the DistributedSystem settings. Did that not work? It would let the test finish faster than keeping the default member-timeout setting and increasing the wait-criterion timeout.
- Bruce Schuchardt
On April 5, 2016, 9:54 p.m., Jianxia Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45780/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 9:54 p.m.)
>
>
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Increase the waiting time.
>
> The bug is really hard to reproduce. By analyzing the stack trace and the code, it is likely the test does not give enough time to allow the change of coordinator, if the system is busy (e.g. GC)
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java b3cc86c
>
> Diff: https://reviews.apache.org/r/45780/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jianxia Chen
>
>