[GitHub] [iceberg] rdblue commented on a change in pull request #1165: Make CharSequenceSet thread safe

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1165:
URL: https://github.com/apache/iceberg/pull/1165#discussion_r449916239



##########
File path: api/src/main/java/org/apache/iceberg/util/CharSequenceSet.java
##########
@@ -54,10 +54,21 @@ public boolean isEmpty() {
     return wrapperSet.isEmpty();
   }
 
+  public CharSequenceWrapper wrapper() {

Review comment:
       Thanks for pointing this out. I didn't know about `Suppliers.memoize` and it looks useful.
   
   I'm not sure that we want to use it here. We've had quite a few problems with Guava and have finally decided to shade just the classes we use into an Iceberg module. I think it is probably better to avoid adding to the set of Guava classes that we use. Since this is already done and it doesn't look like there is much of a benefit to changing over to Guava, I'm inclined to leave it as it is.
   
   If others feel strongly about this, I can use it, but I think we should avoid expanding our use of Guava.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org