[jira] [Updated] (SQOOP-1583) Sqoop2: DerbyRepository Upgrade testing code cleanup

["Veena Basavaraj (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SQOOP-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Veena Basavaraj updated SQOOP-1583:
-----------------------------------
    Description: 
See comments in the https://reviews.apache.org/r/26657/ for context on why we need this JIRA.

sqoop derby repository schema handler and its corresponding test code for upgrades are very brittle.

For instance, renaming a field in the repository table does not really break any test immediately, nor does the developer get any indication that a upgrade query must be written to enforce this.

We should fix this to guard developers from making changes to schema and not creating a corresponding upgrade script. 

Second, the tests needs not have to copy paste the same query code to validate that the upgrade is working, we should be able to share the query code in such a way that any new upgrade code added to the repository handler breaks the tests automatically.



  was:
 fix the upgrade logic for 1498 changes.

While fixing the upgrade logic, added comments on how the upgrade logic works.

-renamed test methods to reflect what they are upgrading and what they are infact testing. 
-renamed the internals to exactly mean "schema" upgrades, since we only allow/ do scheme upgrades the repository
-Also updated the names on the repository api to clearly state the difference between upgrade and update operations on connector / driver.





> Sqoop2: DerbyRepository Upgrade testing code cleanup
> ----------------------------------------------------
>
>                 Key: SQOOP-1583
>                 URL: https://issues.apache.org/jira/browse/SQOOP-1583
>             Project: Sqoop
>          Issue Type: Improvement
>            Reporter: Veena Basavaraj
>            Assignee: Veena Basavaraj
>
> See comments in the https://reviews.apache.org/r/26657/ for context on why we need this JIRA.
> sqoop derby repository schema handler and its corresponding test code for upgrades are very brittle.
> For instance, renaming a field in the repository table does not really break any test immediately, nor does the developer get any indication that a upgrade query must be written to enforce this.
> We should fix this to guard developers from making changes to schema and not creating a corresponding upgrade script. 
> Second, the tests needs not have to copy paste the same query code to validate that the upgrade is working, we should be able to share the query code in such a way that any new upgrade code added to the repository handler breaks the tests automatically.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)