DO NOT REPLY [Bug 37710] New: - [resources] JDBCResources Refactoring

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=37710>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37710

           Summary: [resources] JDBCResources Refactoring
           Product: Commons
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Resources
        AssignedTo: commons-dev@jakarta.apache.org
        ReportedBy: niallp@apache.org


IMO JDBCResources needs to be refactored. Currently it reads the JDBC 
configuration properties each time it loads the messages for a Locale.

It would be better if this file was read once in the JDBCResources's init() 
method which would remove unnecessary duplicate processing and (more 
importantly) mean that if there are any issues with that configuration file 
then Exceptions get thrown at an earlier point in the process (i.e when 
JDBCResources are created).

Additionally it would be good to validate (in the init() method) that the 
properties expected in that file are present and throw a ResourcesException if 
not.

Also, I think we should create a protected getConnection() method - making it 
easier for people to provide a different mechanism for getting hold of a 
connection.

I have this coded, but not yet tested.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org