You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ad...@apache.org on 2011/11/15 13:54:41 UTC

svn commit: r1202164 - /ofbiz/branches/20111115ScreenWidgetRedesign/

Author: adrianc
Date: Tue Nov 15 12:54:41 2011
New Revision: 1202164

URL: http://svn.apache.org/viewvc?rev=1202164&view=rev
Log:
Created a branch to work on implementing the visitor pattern in the screen widget model classes - https://issues.apache.org/jira/browse/OFBIZ-3774. This branch can also be used to explore any other enhancements to the screen widget models.

Added:
    ofbiz/branches/20111115ScreenWidgetRedesign/   (props changed)
      - copied from r1202162, ofbiz/trunk/

Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Tue Nov 15 12:54:41 2011
@@ -0,0 +1,10 @@
+ofbiz.jar
+bin
+*.patch
+*.iml
+*.ipr
+*.iws
+*.time
+.settings
+.project
+changelog

Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
------------------------------------------------------------------------------
--- svn:mergeinfo (added)
+++ svn:mergeinfo Tue Nov 15 12:54:41 2011
@@ -0,0 +1,4 @@
+/ofbiz/branches/addbirt:831210-885099,885686-886087
+/ofbiz/branches/dojo1.4:951708-952957
+/ofbiz/branches/jquery:952958-1044489
+/ofbiz/branches/multitenant20100310:921280-927264



Re: svn commit: r1202164 - /ofbiz/branches/20111115ScreenWidgetRedesign/

Posted by Nicolas Malin <ma...@librenberry.net>.
Le 23/11/2011 22:56, Adrian Crum a écrit :
> I agree that there are many improvements that can be made to the 
> screen widgets. If you would like to submit patches against the 
> branch, then you are welcome to do so.

Ok thanks Adrian, I check with my team and will open jira issue for each 
improvement

Nicolas

>
> -Adrian
>
> On 11/23/2011 9:39 PM, Nicolas Malin wrote:
>> Oops scuse me bad english review :/
>>
>> Hi Adrian,
>>
>> Thanks for your screen engine enhancement and the branch creation.
>> We have most screen engine improvements in our addons library that we 
>> wish give them to Apache OFBiz community.
>> Some one are already available as  jira issues, some are still addons 
>> (eg. portlet system improvement for management screen, ...) and will 
>> be finalized in a few time and other just POCs (like icons usage).
>>
>> We'd like to change the fieldInfo creation in a similar manner as the 
>> screen when loading widgets. This way, we would use a WidgetFactory, 
>> with a loadStandardWidgets() for standard widgets, and an usage 
>> similar to ServiceLoader for other widgets.
>>
>> Are you interested by own features ?
>> For existing jira issues, do I have to change the target version from 
>> trunk to 20111115ScreenWidgetRedesign ?
>>
>> Nicolas
>>
>>
>> Le 15/11/2011 13:54, adrianc@apache.org a écrit :
>>> Author: adrianc
>>> Date: Tue Nov 15 12:54:41 2011
>>> New Revision: 1202164
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1202164&view=rev
>>> Log:
>>> Created a branch to work on implementing the visitor pattern in the 
>>> screen widget model classes - 
>>> https://issues.apache.org/jira/browse/OFBIZ-3774. This branch can 
>>> also be used to explore any other enhancements to the screen widget 
>>> models.
>>>
>>> Added:
>>>      ofbiz/branches/20111115ScreenWidgetRedesign/   (props changed)
>>>        - copied from r1202162, ofbiz/trunk/
>>>
>>> Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
>>> ------------------------------------------------------------------------------ 
>>>
>>> --- svn:ignore (added)
>>> +++ svn:ignore Tue Nov 15 12:54:41 2011
>>> @@ -0,0 +1,10 @@
>>> +ofbiz.jar
>>> +bin
>>> +*.patch
>>> +*.iml
>>> +*.ipr
>>> +*.iws
>>> +*.time
>>> +.settings
>>> +.project
>>> +changelog
>>>
>>> Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
>>> ------------------------------------------------------------------------------ 
>>>
>>> --- svn:mergeinfo (added)
>>> +++ svn:mergeinfo Tue Nov 15 12:54:41 2011
>>> @@ -0,0 +1,4 @@
>>> +/ofbiz/branches/addbirt:831210-885099,885686-886087
>>> +/ofbiz/branches/dojo1.4:951708-952957
>>> +/ofbiz/branches/jquery:952958-1044489
>>> +/ofbiz/branches/multitenant20100310:921280-927264
>>>
>>>
>>
>>


-- 
Nicolas MALIN
Consultant
Tél : 06.17.66.40.06
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : 02.48.02.56.12
Site : http://www.librenberry.net/


Re: svn commit: r1202164 - /ofbiz/branches/20111115ScreenWidgetRedesign/

Posted by Adrian Crum <ad...@sandglass-software.com>.
I agree that there are many improvements that can be made to the screen 
widgets. If you would like to submit patches against the branch, then 
you are welcome to do so.

-Adrian

On 11/23/2011 9:39 PM, Nicolas Malin wrote:
> Oops scuse me bad english review :/
>
> Hi Adrian,
>
> Thanks for your screen engine enhancement and the branch creation.
> We have most screen engine improvements in our addons library that we 
> wish give them to Apache OFBiz community.
> Some one are already available as  jira issues, some are still addons 
> (eg. portlet system improvement for management screen, ...) and will 
> be finalized in a few time and other just POCs (like icons usage).
>
> We'd like to change the fieldInfo creation in a similar manner as the 
> screen when loading widgets. This way, we would use a WidgetFactory, 
> with a loadStandardWidgets() for standard widgets, and an usage 
> similar to ServiceLoader for other widgets.
>
> Are you interested by own features ?
> For existing jira issues, do I have to change the target version from 
> trunk to 20111115ScreenWidgetRedesign ?
>
> Nicolas
>
>
> Le 15/11/2011 13:54, adrianc@apache.org a écrit :
>> Author: adrianc
>> Date: Tue Nov 15 12:54:41 2011
>> New Revision: 1202164
>>
>> URL: http://svn.apache.org/viewvc?rev=1202164&view=rev
>> Log:
>> Created a branch to work on implementing the visitor pattern in the 
>> screen widget model classes - 
>> https://issues.apache.org/jira/browse/OFBIZ-3774. This branch can 
>> also be used to explore any other enhancements to the screen widget 
>> models.
>>
>> Added:
>>      ofbiz/branches/20111115ScreenWidgetRedesign/   (props changed)
>>        - copied from r1202162, ofbiz/trunk/
>>
>> Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
>> ------------------------------------------------------------------------------ 
>>
>> --- svn:ignore (added)
>> +++ svn:ignore Tue Nov 15 12:54:41 2011
>> @@ -0,0 +1,10 @@
>> +ofbiz.jar
>> +bin
>> +*.patch
>> +*.iml
>> +*.ipr
>> +*.iws
>> +*.time
>> +.settings
>> +.project
>> +changelog
>>
>> Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
>> ------------------------------------------------------------------------------ 
>>
>> --- svn:mergeinfo (added)
>> +++ svn:mergeinfo Tue Nov 15 12:54:41 2011
>> @@ -0,0 +1,4 @@
>> +/ofbiz/branches/addbirt:831210-885099,885686-886087
>> +/ofbiz/branches/dojo1.4:951708-952957
>> +/ofbiz/branches/jquery:952958-1044489
>> +/ofbiz/branches/multitenant20100310:921280-927264
>>
>>
>
>

Re: svn commit: r1202164 - /ofbiz/branches/20111115ScreenWidgetRedesign/

Posted by Nicolas Malin <ma...@librenberry.net>.
Oops scuse me bad english review :/

Hi Adrian,

Thanks for your screen engine enhancement and the branch creation.
We have most screen engine improvements in our addons library that we 
wish give them to Apache OFBiz community.
Some one are already available as  jira issues, some are still addons 
(eg. portlet system improvement for management screen, ...) and will be 
finalized in a few time and other just POCs (like icons usage).

We'd like to change the fieldInfo creation in a similar manner as the 
screen when loading widgets. This way, we would use a WidgetFactory, 
with a loadStandardWidgets() for standard widgets, and an usage similar 
to ServiceLoader for other widgets.

Are you interested by own features ?
For existing jira issues, do I have to change the target version from 
trunk to 20111115ScreenWidgetRedesign ?

Nicolas


Le 15/11/2011 13:54, adrianc@apache.org a écrit :
> Author: adrianc
> Date: Tue Nov 15 12:54:41 2011
> New Revision: 1202164
>
> URL: http://svn.apache.org/viewvc?rev=1202164&view=rev
> Log:
> Created a branch to work on implementing the visitor pattern in the screen widget model classes - https://issues.apache.org/jira/browse/OFBIZ-3774. This branch can also be used to explore any other enhancements to the screen widget models.
>
> Added:
>      ofbiz/branches/20111115ScreenWidgetRedesign/   (props changed)
>        - copied from r1202162, ofbiz/trunk/
>
> Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
> ------------------------------------------------------------------------------
> --- svn:ignore (added)
> +++ svn:ignore Tue Nov 15 12:54:41 2011
> @@ -0,0 +1,10 @@
> +ofbiz.jar
> +bin
> +*.patch
> +*.iml
> +*.ipr
> +*.iws
> +*.time
> +.settings
> +.project
> +changelog
>
> Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
> ------------------------------------------------------------------------------
> --- svn:mergeinfo (added)
> +++ svn:mergeinfo Tue Nov 15 12:54:41 2011
> @@ -0,0 +1,4 @@
> +/ofbiz/branches/addbirt:831210-885099,885686-886087
> +/ofbiz/branches/dojo1.4:951708-952957
> +/ofbiz/branches/jquery:952958-1044489
> +/ofbiz/branches/multitenant20100310:921280-927264
>
>


-- 
Nicolas MALIN
Consultant
Tél : 06.17.66.40.06
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : 02.48.02.56.12
Site : http://www.librenberry.net/


Re: svn commit: r1202164 - /ofbiz/branches/20111115ScreenWidgetRedesign/

Posted by Nicolas Malin <ma...@librenberry.net>.
Hi Adrian,

Thanks for your screen engine enhancement and the branch creation.
We have most screen engine improvement on addons library that we wish 
give to Apache OFBiz community.
Some one are on jira issue, some one on addons (portlet system 
improvement for management screen, ...) and will finalized in few time 
and other just on poc (as icons).

We'd like to change the fieldInfo creation in a similar manner as the 
screen when loading widgets. This way, we would use a WidgetFactory, 
with a loadStandardWidgets() for standard widgets, and an usage similar 
to ServiceLoader for other widgets.

Do you interested by own features ?
For existent jira issue, I change the target version from trunk to 
20111115ScreenWidgetRedesign ?

Nicolas


Le 15/11/2011 13:54, adrianc@apache.org a écrit :
> Author: adrianc
> Date: Tue Nov 15 12:54:41 2011
> New Revision: 1202164
>
> URL: http://svn.apache.org/viewvc?rev=1202164&view=rev
> Log:
> Created a branch to work on implementing the visitor pattern in the screen widget model classes - https://issues.apache.org/jira/browse/OFBIZ-3774. This branch can also be used to explore any other enhancements to the screen widget models.
>
> Added:
>      ofbiz/branches/20111115ScreenWidgetRedesign/   (props changed)
>        - copied from r1202162, ofbiz/trunk/
>
> Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
> ------------------------------------------------------------------------------
> --- svn:ignore (added)
> +++ svn:ignore Tue Nov 15 12:54:41 2011
> @@ -0,0 +1,10 @@
> +ofbiz.jar
> +bin
> +*.patch
> +*.iml
> +*.ipr
> +*.iws
> +*.time
> +.settings
> +.project
> +changelog
>
> Propchange: ofbiz/branches/20111115ScreenWidgetRedesign/
> ------------------------------------------------------------------------------
> --- svn:mergeinfo (added)
> +++ svn:mergeinfo Tue Nov 15 12:54:41 2011
> @@ -0,0 +1,4 @@
> +/ofbiz/branches/addbirt:831210-885099,885686-886087
> +/ofbiz/branches/dojo1.4:951708-952957
> +/ofbiz/branches/jquery:952958-1044489
> +/ofbiz/branches/multitenant20100310:921280-927264
>
>


-- 
Nicolas MALIN
Consultant
Tél : 06.17.66.40.06
Site projet : http://www.neogia.org/
-------
Société LibrenBerry
Tél : 02.48.02.56.12
Site : http://www.librenberry.net/