You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "VictorPavfurious (via GitHub)" <gi...@apache.org> on 2025/04/29 08:12:51 UTC
[PR] FINERACT-2238: Refactor under new concept business date api; [fineract]
VictorPavfurious opened a new pull request, #4632:
URL: https://github.com/apache/fineract/pull/4632
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2238: Refactor under new concept business date api; [fineract]
Posted by "VictorPavfurious (via GitHub)" <gi...@apache.org>.
VictorPavfurious commented on PR #4632:
URL: https://github.com/apache/fineract/pull/4632#issuecomment-2840991678
@vidakovic please check it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2238: New command processing - Business Date Management (org.apache.fineract.infrastructure.businessdate) [fineract]
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic closed pull request #4632: FINERACT-2238: New command processing - Business Date Management (org.apache.fineract.infrastructure.businessdate)
URL: https://github.com/apache/fineract/pull/4632
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2238: New command processing - Business Date Management (org.apache.fineract.infrastructure.businessdate) [fineract]
Posted by "vidakovic (via GitHub)" <gi...@apache.org>.
vidakovic commented on PR #4632:
URL: https://github.com/apache/fineract/pull/4632#issuecomment-3003681584
Too much confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2238: Refactor under new concept business date api; [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #4632:
URL: https://github.com/apache/fineract/pull/4632#discussion_r2093222475
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/businessdate/service/BusinessDateWritePlatformServiceImpl.java:
##########
@@ -50,54 +45,31 @@
@RequiredArgsConstructor
public class BusinessDateWritePlatformServiceImpl implements BusinessDateWritePlatformService {
- private final BusinessDateDataParserAndValidator dataValidator;
private final BusinessDateRepository repository;
private final ConfigurationDomainService configurationDomainService;
+ private final BusinessDateUpdateRequestMapper updateRequestMapper;
+ private final BusinessDateMapper responseMapper;
@Override
- public CommandProcessingResult updateBusinessDate(@NotNull final JsonCommand command) {
- BusinessDateData data = dataValidator.validateAndParseUpdate(command);
- Map<String, Object> changes = new HashMap<>();
- adjustDate(data, changes);
- return new CommandProcessingResultBuilder().withCommandId(command.commandId()).with(changes).build();
+ public BusinessDateResponse updateBusinessDate(BusinessDateUpdateRequest request) {
+ BusinessDateDto businessDateDto = updateRequestMapper.map(request);
Review Comment:
If its useless remove it... if you want to have DTO separation between API and Service, you need to following the above listed steps and create a couple extra DTO and move this transformation to the right place...
However we should avoid half baked solutions...
I leave it you and @vidakovic decide on whether this is something you are happy to implement or not...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2238: New command processing - Business Date Management (org.apache.fineract.infrastructure.businessdate) [fineract]
Posted by "VictorPavfurious (via GitHub)" <gi...@apache.org>.
VictorPavfurious commented on PR #4632:
URL: https://github.com/apache/fineract/pull/4632#issuecomment-2962006418
@vidakovic , @galovics , @adamsaghy
Hey team, any updates on this task? Do we have a shared understanding yet? It would be great to align on one concept together and merge it to dev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org