[jira] Resolved: (SHINDIG-671) setUserPref problems in gadgets.js

["Paul Lindner (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SHINDIG-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-671.
----------------------------------

       Resolution: Later
    Fix Version/s: trunk

looks good, patch applied.

> setUserPref problems in gadgets.js
> ----------------------------------
>
>                 Key: SHINDIG-671
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-671
>             Project: Shindig
>          Issue Type: Bug
>          Components: Sample container & Examples
>         Environment: FireFox
>            Reporter: David Citron
>             Fix For: trunk
>
>         Attachments: shindig-671.patch
>
>
> gadgets.IfrGadgetService.prototype.setUserPref appears to have multiple issues:
> 1) its callback registration looses the "this" pointer, causing JS errors (cannot find other methods in its object)
> 2) it does not handle the case where the gadget does not yet have prefs set (prefs undefined error)
> I will attach a patch that worked for me to resolve these issues. Please take a look and determine if the patch is correct or if perhaps some usage pattern of mine is causing the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.