You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/09 08:38:05 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2386: Decouple parquet fuzz tests from converter (#1661)
tustvold opened a new pull request, #2386:
URL: https://github.com/apache/arrow-rs/pull/2386
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #1661
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Part of moving away from ComplexObjectArrayReader is migrating the tests away from using its implementation details. This does this for the parquet fuzz tests
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2386: Decouple parquet fuzz tests from converter (#1661)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2386:
URL: https://github.com/apache/arrow-rs/pull/2386#issuecomment-1212367801
Benchmark runs are scheduled for baseline = b6b1ffd9e0ab0883ff33e01113ebf550ba319cbe and contender = 51274900aa685d44c5f0a7f9536061a2d06525d8. 51274900aa685d44c5f0a7f9536061a2d06525d8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/61a56664ec654d8bacc61aeef49f4c7d...64a8ec526ce74b3db2796eff050a2110/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/cb70680607694ad4a7c7bc3e9e84e76a...755c55a926af4a3da1a5ee2a612bc22f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/27c2092e3c684a49b150304e0091157b...ff308a32a2d14316801929e33c837ebe/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4b4426b129174b5a98ac010f411f1be8...6faa8a61a53d4af39cf4f473ddb187bb/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2386: Decouple parquet fuzz tests from converter (#1661)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2386:
URL: https://github.com/apache/arrow-rs/pull/2386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #2386: Decouple parquet fuzz tests from converter (#1661)
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2386:
URL: https://github.com/apache/arrow-rs/pull/2386#discussion_r943405047
##########
parquet/src/arrow/arrow_reader.rs:
##########
@@ -561,33 +560,23 @@ mod tests {
#[test]
fn test_fixed_length_binary_column_reader() {
let converter = FixedSizeArrayConverter::new(20);
- run_single_column_reader_tests::<
- FixedLenByteArrayType,
- FixedSizeBinaryArray,
- FixedSizeArrayConverter,
- RandFixedLenGen,
- >(
+ run_single_column_reader_tests::<FixedLenByteArrayType, _, RandFixedLenGen>(
Review Comment:
It took me a while to grok this, so I figured I would note it for any other reviewers:
The reduction of generic arguments isn't a change in coverage (the same types are still covered) it is simply fewer generics required to express the same test (in this case on `FixedLenByteArrayType` 👍 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2386: Decouple parquet fuzz tests from converter (#1661)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2386:
URL: https://github.com/apache/arrow-rs/pull/2386#discussion_r941063962
##########
parquet/src/arrow/arrow_reader.rs:
##########
@@ -561,33 +560,23 @@ mod tests {
#[test]
fn test_fixed_length_binary_column_reader() {
let converter = FixedSizeArrayConverter::new(20);
- run_single_column_reader_tests::<
- FixedLenByteArrayType,
- FixedSizeBinaryArray,
- FixedSizeArrayConverter,
- RandFixedLenGen,
- >(
+ run_single_column_reader_tests::<FixedLenByteArrayType, _, RandFixedLenGen>(
20,
ConvertedType::NONE,
None,
- &converter,
+ |vals| Arc::new(converter.convert(vals.to_vec()).unwrap()),
Review Comment:
Until #2318 these types still use the converter plumbing=
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #2386: Decouple parquet fuzz tests from converter (#1661)
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #2386:
URL: https://github.com/apache/arrow-rs/pull/2386#discussion_r941064441
##########
parquet/src/arrow/buffer/converter.rs:
##########
@@ -27,10 +27,7 @@ use crate::errors::Result;
use std::marker::PhantomData;
#[cfg(test)]
-use arrow::array::{
- BinaryArray, BinaryBuilder, LargeStringArray, LargeStringBuilder, StringArray,
- StringBuilder,
-};
+use arrow::array::{StringArray, StringBuilder};
Review Comment:
Sadly we need to keep StringArrrayConverter for now as it used by the ComplexObjectArrayReader tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org