Updated jxpath to 1.2 again.

[Antonio Gallardo <ag...@agssa.net>]

Hi:

I made a change in cli.xconf and now jxpath 1.2 is working.

Please test it.

Best Regards,

Antonio Gallardo

Re: Updated jxpath to 1.2 again.

[Nicola Ken Barozzi <ni...@apache.org>]

David Crossley wrote:
> Antonio Gallardo wrote:
> 
>>
>> I made a change in cli.xconf and now jxpath 1.2 is working.
>>
>> Please test it.
> 
> Thanks Antonio. I did a minimal test
> with './build.sh test'
> 
> However, with the movement of stuff to plugins,
> i am not sure if doing 'build test' is sufficient.
> 
> Doing 'cd forrest/docs-author; forrest'
> shows lots of skipping of "site:*" URLs.
> This is not right.

BTW, IMHO this is a good reason to bring all this handling inside 
Forrest and deal with it here.

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------

Re: whitespace again (was: Updated jxpath to 1.2 again.)

[Antonio Gallardo <ag...@agssa.net>]

On Mar, 7 de Diciembre de 2004, 0:15, David Crossley dijo:
> Antonio Gallardo wrote:
>> David Crossley dijo:
>>
>>>By the way, it was difficult to see from the
>>>diff emails what was changed in cocoon.xconf
>>>It would be better to do whitespace changes
>>>as separate commits.
>>
>> Yes, I noted that. jEdit, automatically remove trailing spaces. :-(
>>
>> I will try to take care next time. ;-)
>
> We had a huge discussion on this a while ago
> at cocoon-dev. Editors that mess with whitespace
> are dangerous. What we agreed there, was that
> occasionally a committer who has a proper editor
> should correct the whitespace across all files in
> one batch, applying a set of whitespace rules.
>
> http://cocoon.apache.org/community/committer.html#whitespace

Ok. I will try to be carefully.

Best Regards,

Antonio Gallardo

whitespace again (was: Updated jxpath to 1.2 again.)

[David Crossley <cr...@apache.org>]

Antonio Gallardo wrote:
> David Crossley dijo:
> 
>>By the way, it was difficult to see from the
>>diff emails what was changed in cocoon.xconf
>>It would be better to do whitespace changes
>>as separate commits.
> 
> Yes, I noted that. jEdit, automatically remove trailing spaces. :-(
> 
> I will try to take care next time. ;-)

We had a huge discussion on this a while ago
at cocoon-dev. Editors that mess with whitespace
are dangerous. What we agreed there, was that
occasionally a committer who has a proper editor
should correct the whitespace across all files in
one batch, applying a set of whitespace rules.

http://cocoon.apache.org/community/committer.html#whitespace

--David

Re: Updated jxpath to 1.2 again.

[Antonio Gallardo <ag...@agssa.net>]

On Lun, 6 de Diciembre de 2004, 22:43, David Crossley dijo:
> By the way, it was difficult to see from the
> diff emails what was changed in cocoon.xconf
> It would be better to do whitespace changes
> as separate commits.

Yes, I noted that. jEdit, automatically remove trailing spaces. :-(

I will try to take care next time. ;-)

Best Regards,

Antonio Gallardo

Re: Updated jxpath to 1.2 again.

[David Crossley <cr...@apache.org>]

Antonio Gallardo wrote:
>
> I made a change in cli.xconf and now jxpath 1.2 is working.
> 
> Please test it.

Thanks Antonio. I did a minimal test
with './build.sh test'

However, with the movement of stuff to plugins,
i am not sure if doing 'build test' is sufficient.

Doing 'cd forrest/docs-author; forrest'
shows lots of skipping of "site:*" URLs.
This is not right.

I rolled back to SVN r109948 (which was just
before the jxpath change) and it doesn't
happen there (... well there are a couple of
oddities, but not like trunk).

By the way, it was difficult to see from the
diff emails what was changed in cocoon.xconf
It would be better to do whitespace changes
as separate commits.

--David