You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/20 19:02:16 UTC

[GitHub] [airflow] BasPH commented on a change in pull request #5874: [AIRFLOW-5268] Apply same DAG naming conventions as in literature

BasPH commented on a change in pull request #5874: [AIRFLOW-5268] Apply same DAG naming conventions as in literature
URL: https://github.com/apache/airflow/pull/5874#discussion_r315854116
 
 

 ##########
 File path: airflow/models/dag.py
 ##########
 @@ -227,7 +227,7 @@ def __init__(
         self._description = description
         # set file location to caller source path
         self.fileloc = sys._getframe().f_back.f_code.co_filename
-        self.task_dict = dict()  # type: Dict[str, TaskInstance]
+        self.task_dict = dict()  # type: Dict[str, BaseOperator]
 
 Review comment:
   Yes :( We actually fill it with Operators, not TaskInstances. The mixing of "operator" and "task" throughout the codebase is rather confusing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services