[GitHub] [flink] hequn8128 opened a new pull request #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule

[GitBox <gi...@apache.org>]

hequn8128 opened a new pull request #8493: [FLINK-12562][table] Improve code in ExpandColumnFunctionsRule
URL: https://github.com/apache/flink/pull/8493
 
 
   
   ## What is the purpose of the change
   
   This pull requests resolve IntelliJ warnings in `ExpandColumnFunctionsRule`. Also, change TableException to ValidationException for the validation as `ValidationException` is used to indicate something wrong from users while `TableException` means unsupported stuff or some weird state for Flink. 
   
   
   ## Brief change log
   
     - Change TableException to ValidationException for validation.
     - Fix code warnings.
     - Adjust tests.
   
   
   ## Verifying this change
   
   
   This change is already covered by existing tests, such as `ColumnFunctionsValidationTest`.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services