[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3731: [WIP DO NOT MERGE] Enable Direct Download for System VMs

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3731: [WIP DO NOT MERGE] Enable Direct Download for System VMs
URL: https://github.com/apache/cloudstack/pull/3731#discussion_r382919720
 
 

 ##########
 File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
 ##########
 @@ -1835,6 +1838,9 @@ public Boolean doInTransaction(final TransactionStatus status) {
                     _vlanDao.remove(vlan.getId());
                 }
 
+                // delete template refs for this zone
+                templateZoneDao.deleteByZoneId(zoneId);
 
 Review comment:
   @shwstppr absolutely only on success. I don't think the zone is still usable if deletion of the zoneVO, but it is not right to do an automatic clean-up of items (templates) in a container (zone) if the container is not disposed of.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services