You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/25 20:49:23 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7032: Fetch
charts with GET to benefit from browser cache and conditional requests
codecov-io commented on issue #7032: Fetch charts with GET to benefit from browser cache and conditional requests
URL: https://github.com/apache/incubator-superset/pull/7032#issuecomment-476371508
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7032?src=pr&el=h1) Report
> Merging [#7032](https://codecov.io/gh/apache/incubator-superset/pull/7032?src=pr&el=desc) into [lyftga](https://codecov.io/gh/apache/incubator-superset/commit/9855837e0ca62906d2825677b8a91bb0e2b7ee5f?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `73.2%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7032/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7032?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## lyftga #7032 +/- ##
==========================================
+ Coverage 64.36% 64.36% +<.01%
==========================================
Files 421 422 +1
Lines 20551 20596 +45
Branches 2249 2261 +12
==========================================
+ Hits 13228 13257 +29
- Misses 7190 7203 +13
- Partials 133 136 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7032?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...rset/assets/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9EYXNoYm9hcmQuanN4) | `0% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydC5qc3g=) | `13.15% <0%> (-0.74%)` | :arrow_down: |
| [...ts/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZVZpZXdDb250YWluZXIuanN4) | `34.04% <0%> (ø)` | :arrow_up: |
| [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==) | `50% <0%> (ø)` | :arrow_up: |
| [...rset/assets/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9EYXNoYm9hcmQuanN4) | `89.28% <100%> (ø)` | :arrow_up: |
| [superset/assets/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2V4cGxvcmVVdGlscy5qcw==) | `76.47% <30%> (-4.39%)` | :arrow_down: |
| [superset/assets/src/chart/chartAction.js](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9jaGFydEFjdGlvbi5qcw==) | `46.21% <70%> (+0.97%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <70%> (-0.44%)` | :arrow_down: |
| [superset/utils/decorators.py](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGVjb3JhdG9ycy5weQ==) | `84.78% <81.08%> (-15.22%)` | :arrow_down: |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | `88.23% <86.2%> (-4.87%)` | :arrow_down: |
| ... and [20 more](https://codecov.io/gh/apache/incubator-superset/pull/7032/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7032?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7032?src=pr&el=footer). Last update [9855837...27c325b](https://codecov.io/gh/apache/incubator-superset/pull/7032?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org