[GitHub] [spark] huaxingao commented on a change in pull request #27245: [SPARK-29212][ML][PYSPARK] Add common classes without using JVM backend

[GitBox <gi...@apache.org>]

huaxingao commented on a change in pull request #27245: [SPARK-29212][ML][PYSPARK] Add common classes without using JVM backend
URL: https://github.com/apache/spark/pull/27245#discussion_r380975541
 
 

 ##########
 File path: python/pyspark/ml/__init__.py
 ##########
 @@ -19,13 +19,16 @@
 DataFrame-based machine learning APIs to let users quickly assemble and configure practical
 machine learning pipelines.
 """
-from pyspark.ml.base import Estimator, Model, Transformer, UnaryTransformer
+from pyspark.ml.base import Estimator, Model, Predictor, PredictionModel, \
+    Transformer, UnaryTransformer
 from pyspark.ml.pipeline import Pipeline, PipelineModel
 from pyspark.ml import classification, clustering, evaluation, feature, fpm, \
     image, pipeline, recommendation, regression, stat, tuning, util, linalg, param
 
 __all__ = [
-    "Transformer", "UnaryTransformer", "Estimator", "Model", "Pipeline", "PipelineModel",
+    "Transformer", "UnaryTransformer", "Estimator", "Model",
+    "Predictor", "PredictionModel",
+    "Pipeline", "PipelineModel",
 
 Review comment:
   super nit: combine these two lines?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org