You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/07 01:59:23 UTC

[GitHub] nswamy commented on a change in pull request #13519: Fix exception handling api doc

nswamy commented on a change in pull request #13519: Fix exception handling api doc
URL: https://github.com/apache/incubator-mxnet/pull/13519#discussion_r239676053
 
 

 ##########
 File path: python/mxnet/ndarray/ndarray.py
 ##########
 @@ -157,6 +157,11 @@ def waitall():
     """Wait for all async operations to finish in MXNet.
 
     This function is used for benchmarking only.
 
 Review comment:
   Not many people will understand what Rethrowing exception means. I suggest the below:
   
   . warning:: This API is for internal purpose  for benchmarking) , it does not do any error handling and can cause silent failures. Use it only if you are confident that your code error free, suggested to call `wait_to_read` on all outputs after `waitall`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services