You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2020/05/19 11:29:40 UTC

[GitHub] [incubator-daffodil] stevedlawrence commented on a change in pull request #384: Validate PadCharacter with pattern facet

stevedlawrence commented on a change in pull request #384:
URL: https://github.com/apache/incubator-daffodil/pull/384#discussion_r427224841



##########
File path: daffodil-core/src/test/resources/test/example-of-most-dfdl-constructs.dfdl.xml
##########
@@ -249,7 +249,8 @@
     <annotation>
       <appinfo source="http://www.ogf.org/dfdl/">
         <dfdl:element nilKind="literalValue" />
-       <!--  Gives a not yet implemented, so commented out.
+       <!--  Gives a SDE: newVariableInstance may only be used on
+            group reference, sequence or choice, so needs review (5/18/20).

Review comment:
       This should probably be moved to a model group in this file. Doesn't neccesarily need to be done as part of this commit. Could be done as a new PR as an update to DAFFODIL-341 along with the other newVariableInstance changes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org