You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/01 21:25:04 UTC
[jira] [Commented] (TS-3718) Unused members in LogFile.h
[ https://issues.apache.org/jira/browse/TS-3718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610864#comment-14610864 ]
ASF GitHub Bot commented on TS-3718:
------------------------------------
GitHub user danobi opened a pull request:
https://github.com/apache/trafficserver/pull/239
TS-3718 Remove unused member variables/functions
read_metadata() and m_size_bytes are not used anywhere
in the code base.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danobi/trafficserver TS-3718
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/239.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #239
----
commit 71b6fe52527620bb0583168f7d31eab17ad95409
Author: Daniel Xu <da...@yahoo-inc.com>
Date: 2015-07-01T19:21:09Z
TS-3718 Remove unused member variables/functions
read_metadata() and m_size_bytes are not used anywhere
in the code base.
----
> Unused members in LogFile.h
> ---------------------------
>
> Key: TS-3718
> URL: https://issues.apache.org/jira/browse/TS-3718
> Project: Traffic Server
> Issue Type: Improvement
> Components: Logging
> Reporter: Daniel Xu
> Priority: Trivial
>
> read_metadata() is declared in LogFile.h, but not defined anywhere in the code base. It is also not referenced anywhere else.
> m_size_bytes is a public variable initialized to 0 in the default LogFile constructor, however, it is not used or referenced anywhere in the code base.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)