[GitHub] [ignite-3] kgusakov commented on a diff in pull request #2581: IGNITE-20344 Fix rebalance recovery and add tests

["kgusakov (via GitHub)" <gi...@apache.org>]

kgusakov commented on code in PR #2581:
URL: https://github.com/apache/ignite-3/pull/2581#discussion_r1324567222


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2233,9 +2251,11 @@ public CompletableFuture<Void> onUpdate(WatchEvent evt) {
                 }
 
                 try {
-                    assert evt.single();

Review Comment:
   Looks we can leave this assert in place?



##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2317,7 +2346,7 @@ private CompletableFuture<Void> handleChangePendingAssignmentEvent(
         CompletableFuture<Void> localServicesStartFuture;
 
         if (shouldStartLocalServices) {
-            localServicesStartFuture = localPartsByTableIdVv.get(pendingAssignmentsEntry.revision())
+            localServicesStartFuture = localPartsByTableIdVv.get(revision)

Review Comment:
   Again, on oldMap.get(tableId) we can receive null here. If this pendingEntry belongs to table, which is already removed in "future" metastore revision.



##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -2273,7 +2300,8 @@ private CompletableFuture<Void> handleChangePendingAssignmentEvent(Entry pending
                                 replicaGrpId,
                                 tables.get(tblId),

Review Comment:
   So, if we are using revision from future - we can receive null here... I think we should check for null and skip the further operations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org